Streak Behavior

[gazpachoking]

I'm not sure if I have a misunderstanding of how typing streak works, a misconfiguration, or a suggestion for how typing streak could work better.

The problem: I want to be able to use shift much easier within a typing streak, but prevent other home row mod taps fairly aggressively.

What I tried: Configuring streak timeout with a per key setting like shown in the example, where shift has a 0 timeout (mostly for testing, I'd probably use a slightly larger one if I get things working) and others have a larger one.

uint16_t achordion_streak_timeout(uint16_t tap_hold_keycode) {
  // Otherwise, tap_hold_keycode is a mod-tap key.
  uint8_t mod = mod_config(QK_MOD_TAP_GET_MODS(tap_hold_keycode));
  if ((mod & MOD_MASK_SHIFT) != 0) {
    return 0;  // A shorter streak timeout for Shift mod-tap keys.
  } else {
    return 375;  // A longer timeout otherwise.
  }
}

The problem seems to be that if I press shift right after another key, it's the other key's timeout that matters, and it disables the hold behavior of shift. I feel like the way it should work is that I define the timeout needed before any given mod-tap key is pressed, rather than defining the timeout needed after any given key is pressed before any mod-tap works.

I'd appreciate any advice if there is some way to achieve what I want already, or some help figuring out how to modify achordion to do what I want.

EDIT: I guess maybe the current behavior of achordion_streak_timeout is also useful, say if I don't want the streak timer to start when certain keys, maybe like arrows, are pressed.

[gazpachoking]

I may have changed achordion to do what I want. I was flying by the seat of my pants though, so I'm not sure yet if I've created unintended side effects, or if there was something useful about the old behavior I haven't noticed yet. I changed it so that instead of recording a future timeout time when a record comes in, it saves the event time of that record. Then when it sees a hold event for a mod tap key, it checks if the last press was less than the streak timeout value for that mod tap key. If it was, it immediately resolves the press as a tap. I'll give it a few days and see if it's working out to plan.