Lumino

[drashna]

First, I want to say that the Lumino module is awesome, and nice.

However, I have noticed a couple of things:
Because of a deviation between the normal formatting of function calls, a couple of the module functions don't call the sub-functions. (I have a PR for this already: getreuer/qmk-modules#6).
Not a huge issue, since the issue I ran into with it can be worked around easily enough. (namely, I have a hacky config for rgblight to dump it's info into rgb matrix for multiple animations, and need to sync the value settings)

Also, instead of using QK_BOOT to add the shutdown/boot led, there is the shutdown_(module) hook.

Additionally, using the timeout option, it doesn't trigger the timer reset on encoder events nor does it trigger on pointing device movement. This is because it's using process_record_* function to reset the timer. However, it might be better to use last_input_activity_time or last_input_activity_elapsed, as these are reset on any activity (matrix, encoder, and pointing) and can provide a much more unified experience.

[drashna]

Figured out how to get lumino to properly respond to pointing device behavior. Mostly, it's pullling the "default" case from process_record_lumino. It might be worth pulling that code out to a function (as well as the event count part) into separate function(s), to be more easily triggered.

report_mouse_t pointing_device_task_lumino(report_mouse_t mouse_report) {
    static uint16_t last_action = 0;
    // only trigger every 100ms.  This could be configurable, but this seems to be more consistent.
    if (timer_elapsed(last_action) < 100) {
        return pointing_device_task_lumino_kb(mouse_report);
    }
    // don't trigger if there is no movement or button presses (eg, if the reports are being zero'd out).
    if (mouse_report.x || mouse_report.y || mouse_report.h || mouse_report.v || mouse_report.buttons) {
        // event has happened, trigger throttling.
        last_action = timer_read();

        // copy behavior from process_record_lumino:
#ifdef USE_SLEEP_TIMER
        event_count = qadd8(event_count, 1);
#endif // USE_SLEEP_TIMER
        if (awake_value > 0) {
            if (!awake || (anim_start_time && anim_end_value == 0)) {
                anim_play(ANIM_WAKE, awake_value); // Wake up.
            } else {
                update_sleep_timer();
            }
        }
    }
    return pointing_device_task_lumino_kb(mouse_report);
}