Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to provide SENTRY_HTTP_RETRY_DELAY #2165

Open
ganadist opened this issue Sep 27, 2024 · 3 comments
Open

Consider to provide SENTRY_HTTP_RETRY_DELAY #2165

ganadist opened this issue Sep 27, 2024 · 3 comments

Comments

@ganadist
Copy link

I have an issue which is related with uploading mapping.txt file,
And reported it at getsentry/sentry-android-gradle-plugin#764
Then, I got answer that SENTRY_HTTP_MAX_RETRIES env would solve my problem.

After I set SENTRY_HTTP_MAX_RETRIES=25, but I got same issue.
In my experience, when perform :app:uploadSentryProguardMappingsRelease task multiple in this case, upload task can be succeeded.

The difference with increasing the SENTRY_HTTP_MAX_RETRIES value is that it takes quite a bit of time to perform the gradle task.
In sentry-cli upload, if you can give the upload retry a time interval, I think it will provide a similar effect.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Sep 27, 2024
@szokeasaurusrex
Copy link
Member

@ganadist how exactly would being able to configure the retry delay help in your situation? I believe we already have an exponential backoff for retries

@ganadist
Copy link
Author

ganadist commented Oct 2, 2024

In my case, mapping.txt file size is about 800Mb or larger and retry value is set as 25. (I heard that retry value would be enough when it is 10 from Sentry engineer)

And when try again to perform :app:uploadSentryProguardMappingsRelease task several times in manually, I can observe that uploading task can be succeeded.

And duration to perform :app:uploadSentryProguardMappingsRelease is about 3-4 minutes.

It looks max backoff value is 5sec only in sentry-cli.
https://github.com/getsentry/sentry-cli/blob/master/src/constants.rs#L39

Is it possible to provide increased backoff value on sentry cli?

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Oct 2, 2024
@szokeasaurusrex
Copy link
Member

Is it possible to provide increased backoff value on sentry cli?

Currently this is not possible, but we could add this feature.

However, to be clear, the retry occurs after the upload has already failed. So, even though it takes 3-4 minutes to perform the upload, we would still wait 5 seconds after the failure to retry with the current max retry value. We would not retry already 5 seconds after starting the upload. So, I am unsure whether this would fix your problem.

Perhaps, you could try adding a manual retry to your script? Or is the Sentry CLI being called by the Sentry Gradle plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants