Add thorough tests for debug file chunk uploading #2194
Comments
This was referenced Oct 23, 2024
szokeasaurusrex
added a commit
that referenced
this issue
Nov 6, 2024
As a part of #2194, I intend to introduce the [`assert_cmd` crate](https://docs.rs/assert_cmd/latest/assert_cmd/) to have more control over how the assertions for the chunk upload tests are run. This control would be difficult to achieve with `trycmd`. So, here, I am splitting off the logic for setting environment variables to make it also reusable for `assert_cmd` tests
szokeasaurusrex
added a commit
that referenced
this issue
Nov 6, 2024
As a part of #2194, I intend to introduce the [`assert_cmd` crate](https://docs.rs/assert_cmd/latest/assert_cmd/) to have more control over how the assertions for the chunk upload tests are run. This control would be difficult to achieve with `trycmd`. So, here, I am splitting off the logic for setting environment variables to make it also reusable for `assert_cmd` tests
szokeasaurusrex
added a commit
that referenced
this issue
Nov 6, 2024
The [`assert_cmd`](https://docs.rs/assert_cmd/latest/assert_cmd/) crate provides an interface which allows more fine-grained control over how an individual integration test is run compared with the `trycmd` crate we currently use everywhere. `assert_cmd` will help us write better integration tests for chunk uploading, which not only assert command output, but also ensure that the correct data is sent to the Sentry server (see #2194).
szokeasaurusrex
added a commit
that referenced
this issue
Nov 6, 2024
As a part of #2194, I intend to introduce the [`assert_cmd` crate](https://docs.rs/assert_cmd/latest/assert_cmd/) to have more control over how the assertions for the chunk upload tests are run. This control would be difficult to achieve with `trycmd`. So, here, I am splitting off the logic for setting environment variables to make it also reusable for `assert_cmd` tests
szokeasaurusrex
added a commit
that referenced
this issue
Nov 6, 2024
The [`assert_cmd`](https://docs.rs/assert_cmd/latest/assert_cmd/) crate provides an interface which allows more fine-grained control over how an individual integration test is run compared with the `trycmd` crate we currently use everywhere. `assert_cmd` will help us write better integration tests for chunk uploading, which not only assert command output, but also ensure that the correct data is sent to the Sentry server (see #2194).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our current chunk uploading tests don't appear to actually verify that inputting a given file to Sentry CLI for chunk upload produces the expected chunks.
Before refactoring the chunk uploading code to add support for chunk uploading Proguard files, we should add tests that ensure that for a given debug information file, Sentry CLI produces the correct chunks for upload. This way, we can more easily detect if our refactor introduces a change in behavior
The text was updated successfully, but these errors were encountered: