Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breadrumb.origin #4043

Closed
2 tasks done
Tracked by #629
krystofwoldrich opened this issue Jun 10, 2024 · 6 comments · Fixed by #4358 or getsentry/sentry-docs#11449
Closed
2 tasks done
Tracked by #629

Add breadrumb.origin #4043

krystofwoldrich opened this issue Jun 10, 2024 · 6 comments · Fixed by #4358 or getsentry/sentry-docs#11449
Assignees

Comments

@krystofwoldrich
Copy link
Member

Description

Description

Add new runtime property to SentryBreadcrumb called origin, this can be used to identify source of the breadcrumb.

For example hybrid SDKs can identify native breadcrumbs from JS or Flutter.

Required for

Preview Give feedback
  1. Blocked Status: Stale
  2. Platform: React-Native Type: 🪲 Bug
    antonis

Related issues

@krystofwoldrich
Copy link
Member Author

@lucas-zimerman When you open a PR , you can link this issue.

@brustolin brustolin moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Jun 19, 2024
@brustolin brustolin moved this from Backlog to Needs More Information in Mobile & Cross Platform SDK Jun 19, 2024
@kahest kahest moved this from Needs More Information to Backlog in Mobile & Cross Platform SDK Jul 17, 2024
@antonis antonis self-assigned this Sep 20, 2024
@kahest kahest moved this from Backlog to In Progress in Mobile & Cross Platform SDK Sep 20, 2024
@philipphofmann
Copy link
Member

Please update the develop docs before closing this issue.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Mobile & Cross Platform SDK Sep 26, 2024
@antonis
Copy link
Collaborator

antonis commented Sep 26, 2024

Hey @philipphofmann 👋
thank you for the heads up 🙇
Since the new field is private for internal use my understanding is that we don't need to add it in the developer docs. Let me know if this is not the case 🙏

@philipphofmann
Copy link
Member

@antonis, it's still part of the protocol. The developer docs are for SDK maintainers. You don't have to do that, but either @krystofwoldrich, who opened the issue, or one of the Sentry folks should do it.

@antonis
Copy link
Collaborator

antonis commented Sep 27, 2024

Makes sense. Thank you for the feedback Philipp 🙇
I'm reopening the issue till this is tackled.

@antonis
Copy link
Collaborator

antonis commented Sep 27, 2024

Opened a PR updating the documentation that would close this issue getsentry/sentry-docs#11449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants