-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support graphql
APM/Breadcrumbs
#1126
Comments
Actually, the better example is sentry_link. sentry_graphql (permalink to before deletion) doesn't really add value over the link integrations and I've deleted it since. The link integration is also more versatile, since it integrates into a couple different GraphQL clients as mentioned in it's readme. I'm also open to transfer ownership of the https://pub.dev/packages/sentry_link package, if there's interest. |
https://github.com/DiederikvandenB/apollo-link-sentry also uses the Link approach for RN, so using the Link approach would be the way to go. |
Worth checking this discussion before tackling this issue. |
Also, this getsentry/sentry#33723 issue, but I don't think it will be tackled soon. |
I'll drop Client errors for now unless it throws an exception.
The SDK would need to read and deserialize the payload, we'd need to decide if we actually wanna do it and if the response payload is standardized across different Graph implementations. |
graphql
APM/Breadcrumbs/Client errorsgraphql
APM/Breadcrumbs
An additional problem is, that you can have partial errors with GraphQL. |
I'm in the future no longer working with Sentry (😭) and also not longer with GraphQL, so I would like to hand over ownership of https://pub.dev/packages/sentry_link to you. I'm happy to create a PR for moving the code. Regarding the package on pub, I'm happy to discuss how to transfer it via Discord, since it would be really nice if current users would receive new updates from you via the same package. |
Description
https://pub.dev/packages/graphql_flutter
https://pub.dev/packages/graphql
https://pub.dev/documentation/graphql/latest/graphql/QueryResult-class.html
https://pub.dev/documentation/graphql/latest/graphql/GraphQLClient-class.html
Example https://github.com/ueman/sentry-dart-tools/tree/main/sentry_graphql
The text was updated successfully, but these errors were encountered: