Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support graphql APM/Breadcrumbs #1126

Open
marandaneto opened this issue Nov 10, 2022 · 7 comments · May be fixed by #2338
Open

Support graphql APM/Breadcrumbs #1126

marandaneto opened this issue Nov 10, 2022 · 7 comments · May be fixed by #2338

Comments

@ueman
Copy link
Collaborator

ueman commented Nov 10, 2022

Actually, the better example is sentry_link. sentry_graphql (permalink to before deletion) doesn't really add value over the link integrations and I've deleted it since. The link integration is also more versatile, since it integrates into a couple different GraphQL clients as mentioned in it's readme.

I'm also open to transfer ownership of the https://pub.dev/packages/sentry_link package, if there's interest.

@brustolin brustolin moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Nov 24, 2022
@marandaneto
Copy link
Contributor Author

https://github.com/DiederikvandenB/apollo-link-sentry also uses the Link approach for RN, so using the Link approach would be the way to go.

@marandaneto
Copy link
Contributor Author

Worth checking this discussion before tackling this issue.

@ueman
Copy link
Collaborator

ueman commented Jan 17, 2023

Also, this getsentry/sentry#33723 issue, but I don't think it will be tackled soon.

@marandaneto
Copy link
Contributor Author

I'll drop Client errors for now unless it throws an exception.

Unlike REST APIs, GraphQL servers don’t use HTTP status codes to indicate unsuccessful requests. Instead, the GraphQL response body includes an array of errors when an operation fails.

The SDK would need to read and deserialize the payload, we'd need to decide if we actually wanna do it and if the response payload is standardized across different Graph implementations.

@marandaneto marandaneto changed the title Support graphql APM/Breadcrumbs/Client errors Support graphql APM/Breadcrumbs Jan 17, 2023
@ueman
Copy link
Collaborator

ueman commented Jan 17, 2023

The SDK would need to read and deserialize the payload, we'd need to decide if we actually wanna do it and if the response payload is standardized across different Graph implementations.

An additional problem is, that you can have partial errors with GraphQL.
The error response is standardized, as seen here.

@ueman
Copy link
Collaborator

ueman commented Oct 1, 2024

I'm in the future no longer working with Sentry (😭) and also not longer with GraphQL, so I would like to hand over ownership of https://pub.dev/packages/sentry_link to you.
It currently has a popularity of 80%, so it's quite popular (even more than some of your first party integrations), and otherwise I would feel bad to just mark it as deprecated. I also haven't received any bug reports/feature request in the recent past, so seems pretty stable and feature complete.

I'm happy to create a PR for moving the code. Regarding the package on pub, I'm happy to discuss how to transfer it via Discord, since it would be really nice if current users would receive new updates from you via the same package.

@ueman ueman linked a pull request Oct 9, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

4 participants