fix

Author: marandaneto

Makefile

@@ -19,7 +19,9 @@ dryRelease:
 # remember to remove the -SNAPSHOT suffix from the version
 # promotes the release to maven central
 doRelease:
-	./gradlew publish --no-daemon
+	cd scripts
+	kotlinc -script release.kts -- -d ../distributions | sh
+	cd ..
 	./gradlew closeAndReleaseRepository
 
 # clean, build, deploy and promote to maven central

build.gradle.kts

@@ -105,18 +105,14 @@ subprojects {
             apply<MavenPublishPlugin>()
 
             configure<MavenPublishPluginExtension> {
-                val sign = Config.BuildPlugins.shouldSignArtifacts(project.version.toString())
-                releaseSigningEnabled = sign
+                // signing is done when uploading files to MC
+                // via gpg:sign-and-deploy-file (release.kts)
+                releaseSigningEnabled = false
             }
 
-            // signing info and maven central info go to:
+            // maven central info go to:
             // ~/.gradle/gradle.properties
 
-            // signing info:
-            // signing.keyId=id
-            // signing.password=password
-            // signing.secretKeyRingFile=file path
-
             // maven central info:
             // mavenCentralUsername=user name
             // mavenCentralPassword=password

scripts/release.kts

@@ -45,35 +45,52 @@ val repositoryUrl = argOrDefault("repositoryUrl", "https://oss.sonatype.org/serv
 val repositoryId = argOrDefault("repositoryId", "ossrh")
 
 File(path)
-    .listFiles { file -> file.isDirectory() }
-    .forEach { folder ->
-        val path = folder.path
-        val module = folder.name
+        .listFiles { file -> file.isDirectory() }
+        .forEach { folder ->
+            val path = folder.path
+            val module = folder.name
 
-        val file: String
+            val file: String
 
-        val androidFile = folder.listFiles { it -> it.name.contains("release") && it.extension == "aar" }.firstOrNull()
-        if (androidFile != null) {
-            file = androidFile.path
-        } else {
-            file = "$path/$module.jar"
-        }
-        val javadocFile = "$path/$module-javadoc.jar"
-        val sourcesFile = "$path/$module-sources.jar"
-        val pomFile = "$path/pom-default.xml"
+            val androidFile = folder
+                    .listFiles { it -> it.name.contains("release") && it.extension == "aar" }
+                    .firstOrNull()
+
+            if (androidFile != null) {
+                file = androidFile.path
+            } else {
+                file = "$path/$module.jar"
+            }
 
-        val command = "./mvnw deploy:deploy-file -Dfile=$file -Dfiles=$javadocFile,$sourcesFile -Dclassifiers=sources,javadoc -Dtypes=jar,jar -DpomFile=$pomFile -DrepositoryId=$repositoryId -Durl=$repositoryUrl --settings $settingsPath"
-        println(command)
-    }
+            val javadocFile = "$path/$module-javadoc.jar"
+            val sourcesFile = "$path/$module-sources.jar"
+            val pomFile = "$path/pom-default.xml"
+
+            // requires GnuPG installed to sign files
+            // using 'gpg:sign-and-deploy-file' because 'deploy:deploy-file' does not upload
+            // .asc files.
+            // TODO: find out where to set keyId, password and secretKeyRingFile if you have
+            // more than one.
+            val command = "./mvnw gpg:sign-and-deploy-file " +
+                    "-Dfile=$file " +
+                    "-Dfiles=$javadocFile,$sourcesFile " +
+                    "-Dclassifiers=sources,javadoc " +
+                    "-Dtypes=jar,jar " +
+                    "-DpomFile=$pomFile " +
+                    "-DrepositoryId=$repositoryId " +
+                    "-Durl=$repositoryUrl " +
+                    "--settings $settingsPath"
+            println(command)
+        }
 
 /**
  * Returns the value for a command line argument passed with -argName flag or throws an exception if not provided.
  */
 fun Release.requiredArg(argName: String) =
-    if (args.contains("-$argName")) args[1 + args.indexOf("-$argName")] else throw Error("$argName parameter must be provided")
+        if (args.contains("-$argName")) args[1 + args.indexOf("-$argName")] else throw Error("$argName parameter must be provided")
 
 /**
  * Returns the value for a command line argument passed with -argName flag or returns the default value.
  */
 fun Release.argOrDefault(argName: String, default: String) =
-    if (args.contains("-$argName")) args[1 + args.indexOf("-$argName")] else default
+        if (args.contains("-$argName")) args[1 + args.indexOf("-$argName")] else default