fix(replay): Avoid deadlock when pausing replay if no connection (#4788)

Author: romtsn

CHANGELOG.md

@@ -5,6 +5,7 @@
 ### Fixes
 
 - Use logger from options for JVM profiler ([#4771](https://github.com/getsentry/sentry-java/pull/4771))
+- Session Replay: Avoid deadlock when pausing replay if no connection ([#4788](https://github.com/getsentry/sentry-java/pull/4788))
 
 ### Miscellaneous
 

sentry-android-replay/src/main/java/io/sentry/android/replay/ReplayIntegration.kt

@@ -307,15 +307,13 @@ public class ReplayIntegration(
     scopes?.configureScope { screen = it.screen?.substringAfterLast('.') }
     captureStrategy?.onScreenshotRecorded(bitmap) { frameTimeStamp ->
       addFrame(bitmap, frameTimeStamp, screen)
-      checkCanRecord()
     }
+    checkCanRecord()
   }
 
   override fun onScreenshotRecorded(screenshot: File, frameTimestamp: Long) {
-    captureStrategy?.onScreenshotRecorded { _ ->
-      addFrame(screenshot, frameTimestamp)
-      checkCanRecord()
-    }
+    captureStrategy?.onScreenshotRecorded { _ -> addFrame(screenshot, frameTimestamp) }
+    checkCanRecord()
   }
 
   override fun close() {