Drop events when the server returns an HTTP 429. (#613)

Author: bretthoerner

CHANGES

@@ -2,6 +2,7 @@ Version 1.7.10
 --------------
 
 - Android Plugin: Look for properties file directly under flavor directory. (thanks biggestT)
+- Drop events when the server returns an HTTP 429.
 
 Version 1.7.9
 -------------

sentry/src/main/java/io/sentry/connection/BufferedConnection.java

@@ -107,10 +107,10 @@ public void send(Event event) {
             boolean notSerializable = e.getCause() instanceof NotSerializableException;
 
             Integer responseCode = e.getResponseCode();
-            if (notSerializable || (responseCode != null && responseCode != HttpConnection.HTTP_TOO_MANY_REQUESTS)) {
+            if (notSerializable || (responseCode != null)) {
                 // don't retry events (discard from the buffer) if:
                 // 1. they aren't serializable
-                // 2. the connection is up (valid response code was returned) and it's not an HTTP 429
+                // 2. the connection is up (valid response code was returned)
                 buffer.discard(event);
             }
 

sentry/src/test/java/io/sentry/connection/BufferedConnectionTest.java

@@ -156,15 +156,15 @@ public void test500NotBuffered() throws Exception {
     }
 
     @Test
-    public void test429IsBuffered() throws Exception {
+    public void test429IsNotBuffered() throws Exception {
         Event event = new EventBuilder().build();
         connectionException = new ConnectionException("429", new IOException(), null, HttpConnection.HTTP_TOO_MANY_REQUESTS);
         try {
             bufferedConnection.send(event);
         } catch (Exception e) {
 
         }
-        assertThat(bufferedEvents.size(), equalTo(1));
+        assertThat(bufferedEvents.size(), equalTo(0));
     }
 
     @Test