Skip to content

Commit eea8bd7

Browse files
committed
Hook SentryOkHttpInterceptor into SentryReplayOptions
enables Network Detail extraction via SDK and removes FAKE_OPTIONS placeholder
1 parent a2d1e53 commit eea8bd7

File tree

1 file changed

+6
-16
lines changed

1 file changed

+6
-16
lines changed

sentry-okhttp/src/main/java/io/sentry/okhttp/SentryOkHttpInterceptor.kt

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -61,16 +61,6 @@ public open class SentryOkHttpInterceptor(
6161
SentryIntegrationPackageStorage.getInstance()
6262
.addPackage("maven:io.sentry:sentry-okhttp", BuildConfig.VERSION_NAME)
6363
}
64-
65-
/** Fake options for testing network detail capture */
66-
private val FAKE_OPTIONS =
67-
object {
68-
val networkDetailAllowUrls: Array<String> = emptyArray()
69-
val networkDetailDenyUrls: Array<String> = emptyArray()
70-
val networkCaptureBodies: Boolean = false
71-
val networkRequestHeaders: Array<String> = emptyArray()
72-
val networkResponseHeaders: Array<String> = emptyArray()
73-
}
7464
}
7565

7666
public constructor() : this(ScopesAdapter.getInstance())
@@ -119,8 +109,8 @@ public open class SentryOkHttpInterceptor(
119109
NetworkDetailCaptureUtils.initializeForUrl(
120110
request.url.toString(),
121111
request.method,
122-
FAKE_OPTIONS.networkDetailAllowUrls,
123-
FAKE_OPTIONS.networkDetailDenyUrls,
112+
scopes.options.sessionReplay.networkDetailAllowUrls,
113+
scopes.options.sessionReplay.networkDetailDenyUrls,
124114
)
125115

126116
try {
@@ -152,7 +142,7 @@ public open class SentryOkHttpInterceptor(
152142
NetworkDetailCaptureUtils.createRequest(
153143
request,
154144
requestContentLength,
155-
FAKE_OPTIONS.networkCaptureBodies,
145+
scopes.options.sessionReplay.isNetworkCaptureBodies,
156146
{ req ->
157147
req.body?.let { originalBody ->
158148
val buffer = okio.Buffer()
@@ -167,7 +157,7 @@ public open class SentryOkHttpInterceptor(
167157
safeExtractRequestBody(bodyBytes, originalBody.contentType(), scopes.options.logger)
168158
}
169159
},
170-
FAKE_OPTIONS.networkRequestHeaders,
160+
scopes.options.sessionReplay.networkRequestHeaders,
171161
{ req: Request -> req.headers.toMap() },
172162
)
173163
)
@@ -211,9 +201,9 @@ public open class SentryOkHttpInterceptor(
211201
NetworkDetailCaptureUtils.createResponse(
212202
it,
213203
it.body?.contentLength(),
214-
FAKE_OPTIONS.networkCaptureBodies,
204+
scopes.options.sessionReplay.isNetworkCaptureBodies,
215205
{ resp: Response -> resp.extractResponseBody(scopes.options.logger) },
216-
FAKE_OPTIONS.networkResponseHeaders,
206+
scopes.options.sessionReplay.networkResponseHeaders,
217207
{ resp: Response -> resp.headers.toMap() },
218208
),
219209
)

0 commit comments

Comments
 (0)