Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust library may not actually be usable in standalone binaries #106

Open
untitaker opened this issue Apr 13, 2023 · 0 comments
Open

Rust library may not actually be usable in standalone binaries #106

untitaker opened this issue Apr 13, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@untitaker
Copy link
Member

untitaker commented Apr 13, 2023

The Rust library references schema files using filepaths. This only really works if ~/.cargo/cache sticks around. On the other hand, it is quite neat for local development because it means schemas can be edited without having to recompile the Rust part.

It's also been brought up in the past that it would be cool if sentry-kafka-schemas would cache compiled schemas in memory. Maybe both problems can be fixed at once.

The tricky bit with this bug is that IMO the most straightforward solution would involve proc-macros, but those are compile-time heavy. Perhaps it is time to reconsider generating code before cargo publish?

@untitaker untitaker added the bug Something isn't working label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant