Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report events on Android as sentry.native.android.kotlin-multiplatform #313

Closed
bruno-garcia opened this issue Jan 11, 2025 · 1 comment · Fixed by #353
Closed

Report events on Android as sentry.native.android.kotlin-multiplatform #313

bruno-garcia opened this issue Jan 11, 2025 · 1 comment · Fixed by #353

Comments

@bruno-garcia
Copy link
Member

Problem Statement

For events that are captured from sentry.native, that already will be set as sentry.native.android as that's set up at the Android SDK build level. Here the goal is to append "this SDK name" to the end. Resulting in what I believe will be: sentry.native.android.kotlin-multiplatform

This helps understanding where events come from and debug SDK issues more quickly

Solution Brainstorm

Similarly to:

https://github.com/getsentry/sentry-dotnet/blob/c20d16245c7e2d2f9056a49780593a391e59eda1/src/Sentry/Platforms/Android/SentrySdk.cs#L141

https://github.com/getsentry/sentry-capacitor/blob/4aceb63e6d948555ea666e8256ae153dc37e93b3/android/src/main/java/io/sentry/capacitor/SentryCapacitor.java#L40

https://github.com/getsentry/sentry-unity/blob/bee77f39ad1137cb21082721d1a2b5fa9fc6f83d/Directory.Build.targets#L191

https://github.com/getsentry/sentry-unreal/blob/d7d7973d645de4f66328d93aff673d4662be33ef/scripts/build-deps.ps1#L86

@buenaflor
Copy link
Contributor

will add it as sentry.native.android.kmp

@buenaflor buenaflor moved this from Needs Discussion to Todo in Mobile SDKs Jan 13, 2025
@buenaflor buenaflor moved this from Todo to In Progress in Mobile SDKs Apr 3, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Mobile SDKs Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants