Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard dependency on Faraday #1524

Closed
andrewhavens opened this issue Aug 5, 2021 · 3 comments
Closed

Remove hard dependency on Faraday #1524

andrewhavens opened this issue Aug 5, 2021 · 3 comments

Comments

@andrewhavens
Copy link

Describe the idea
There is a hard dependency on Faraday. It is required within http_transport.rb which gets required automatically by transport.rb, even if you don't intend to use the HTTPTransport class.

Why do you think it's beneficial to most of the users
The SDK provides the ability to specify a custom transport (which was really helpful) but sort of defeats the purpose when you have a hard dependency that never gets used. There are also other http gems that people may be using and might not want to require additional http libraries.

Possible implementation
Either remove the hard dependency on requiring Faraday (call require as needed before initializing an http client). Or remove the hard dependency on requiring http_transport.rb.

@st0012 st0012 added this to the 5.0.0 milestone Aug 6, 2021
@st0012
Copy link
Collaborator

st0012 commented Aug 6, 2021

Faraday is a critical component of the current implementation and it's risky to replace it with a lower level Net::HTTP implementation. So it's not at a high priority when rebuilding the new sentry-ruby SDK.

With that being said, we did receive a few complaints of requiring faraday. So I've listed it's removal in the Plan for version 5 a while ago 🙂

@mpeltomaa
Copy link

I have also depency issue with faraday

@iker-barriocanal
Copy link

Closing this issue since the request has been included in the plan for version 5.

@st0012 st0012 removed this from the 5.0.0 milestone Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants