Skip to content

Commit 47753dd

Browse files
committed
updated log check
1 parent cac2a68 commit 47753dd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: scripts/smoke-test-android.ps1

+2-2
Original file line numberDiff line numberDiff line change
@@ -332,8 +332,8 @@ function RunTest([string] $Name, [string] $SuccessString, [string] $FailureStrin
332332
$logCache = ProcessNewLogs -newLogs $newLogs -lastLogCount ([ref]$lastLogCount) -logCache $logCache
333333

334334
# The SmokeTester logs "SmokeTester is quitting." in OnApplicationQuit() to reliably inform when tests finish running.
335-
# For crash tests, we expect to see a native crash log "terminating with uncaught exception of type char const*".
336-
if (($newLogs | Select-String "SmokeTester is quitting.") -or ($newLogs | Select-String "terminating with uncaught exception of type char const*"))
335+
# For crash tests, we're checking for `sentry-native` logging "crash has been captured" to reliably inform when tests finished running.
336+
if (($newLogs | Select-String "SmokeTester is quitting.") -or ($newLogs | Select-String "crash has been captured"))
337337
{
338338
Write-Host "Process finished marker detected. Finish waiting for tests to run."
339339
$processFinished = $true

0 commit comments

Comments
 (0)