Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ./RevisionData/Creators mapping #3

Open
4 tasks done
airnst opened this issue Jul 9, 2024 · 1 comment · May be fixed by #30
Open
4 tasks done

Add ./RevisionData/Creators mapping #3

airnst opened this issue Jul 9, 2024 · 1 comment · May be fixed by #30
Assignees
Labels
enhancement New feature or request mapping_xslt question Further information is requested

Comments

@airnst
Copy link
Collaborator

airnst commented Jul 9, 2024

Description

Dataset creators in ABCD datasets can be mapped to Organization objects that are referenced by the creator property in BioSchemas' Dataset. According to the ABCD specification, their values are plain strings describing an organization.

Files

XSLT file

Open questions

  1. If the string describes a person, how can this case be distinguished from the organization case? Note: The BioSchemas creator property only includes the types Person and Organization as domain.
    Names could be identified by using NLTK taggers. Problem: If an organization is named after one or more persons, it cannot be distinguished from a person entity.
  2. Since abcd:creators is plural: Are multiple creators also separated by comma?

Tasks

  • Implement as single Thing.
  • Resolve open questions.
  • Update file.
  • Test if comma-separated creator names are mapped correctly to lists of entities.
@airnst airnst added enhancement New feature or request question Further information is requested mapping_xslt labels Jul 9, 2024
@airnst airnst self-assigned this Jul 9, 2024
airnst pushed a commit that referenced this issue Jul 9, 2024
@airnst
Copy link
Collaborator Author

airnst commented Jul 9, 2024

Implemented as type Thing for the time being. (see 044832a)

airnst pushed a commit that referenced this issue Jul 30, 2024
@airnst airnst linked a pull request Aug 5, 2024 that will close this issue
@airnst airnst linked a pull request Aug 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mapping_xslt question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant