Skip to content

Commit c1d29b4

Browse files
committed
Updating to v0.2.5
1 parent 79d65d0 commit c1d29b4

File tree

2 files changed

+33
-22
lines changed

2 files changed

+33
-22
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "amdclean",
3-
"version": "0.2.4",
3+
"version": "0.2.5",
44
"description": "A build tool that converts AMD code to standard JavaScript",
55
"main": "./src/amdclean",
66
"repository": {

src/amdclean.js

Lines changed: 32 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! amdclean - v0.2.4 - 2013-10-15
1+
/*! amdclean - v0.2.5 - 2013-10-15
22
* http://gregfranko.com/amdclean
33
* Copyright (c) 2013 Greg Franko; Licensed MIT*/
44

@@ -34,7 +34,7 @@
3434
// The Public API object
3535
publicAPI = {
3636
// Current project version number
37-
VERSION: '0.2.4',
37+
VERSION: '0.2.5',
3838
// Environment - either node or web
3939
env: codeEnv,
4040
// Object that keeps track of module ids/names that are used
@@ -118,18 +118,20 @@
118118
// e.g. require('someModule');
119119
isCommonJS: function(node) {
120120
if(!node) return false;
121-
return (publicAPI.isRequireExpression || publicAPI.isRequireMemberExpression(node) || isRequireCallExpression(node));
121+
return (publicAPI.isRequireExpression(node) || publicAPI.isRequireMemberExpression(node) || publicAPI.isRequireCallExpression(node));
122122
},
123123
// isRequireExpression
124124
// -------------------
125125
// Returns if the current AST node is a require() variable declaration
126126
// e.g. var example = require('someModule');
127127
isRequireExpression: function(node) {
128128
return (node.type === 'VariableDeclarator' &&
129-
!_.isUndefined(node.init) &&
130-
!_.isUndefined(node.init.type) &&
129+
node.id &&
130+
node.id.name &&
131+
node.init &&
132+
node.init.type &&
131133
node.init.type === 'CallExpression' &&
132-
!_.isUndefined(node.init.callee) &&
134+
node.init.callee &&
133135
node.init.callee.name === 'require');
134136
},
135137
// isRequireMemberExpression
@@ -138,11 +140,13 @@
138140
// e.g. var example = require('someModule').someProp;
139141
isRequireMemberExpression: function(node) {
140142
return (node.type === 'VariableDeclarator' &&
141-
!_.isUndefined(node.init) &&
142-
!_.isUndefined(node.init.type) &&
143+
node.id &&
144+
node.id.name &&
145+
node.init &&
146+
node.init.type &&
143147
node.init.type === 'MemberExpression' &&
144-
!_.isUndefined(node.init.object) &&
145-
!_.isUndefined(node.init.object.callee) &&
148+
node.init.object &&
149+
node.init.object.callee &&
146150
node.init.object.callee.name === 'require');
147151
},
148152
// isRequireCallExpression
@@ -151,19 +155,21 @@
151155
// e.g. var example = require('someModule').someProp();
152156
isRequireCallExpression: function(node) {
153157
return (node.type === 'VariableDeclarator' &&
154-
!_.isUndefined(node.init) &&
155-
!_.isUndefined(node.init.type) &&
158+
node.id &&
159+
node.id.name &&
160+
node.init &&
161+
node.init.type &&
156162
node.init.type === 'CallExpression' &&
157-
!_.isUndefined(node.init.callee) &&
163+
node.init.callee &&
158164
node.init.callee.type === 'MemberExpression' &&
159-
!_.isUndefined(node.init.callee.object) &&
160-
!_.isUndefined(node.init.callee.object.type) &&
165+
node.init.callee.object &&
166+
node.init.callee.object.type &&
161167
node.init.callee.object.type === 'CallExpression' &&
162-
!_.isUndefined(node.init.callee.object['arguments']) &&
163-
!_.isUndefined(node.init.callee.object.callee) &&
168+
node.init.callee.object['arguments'] &&
169+
node.init.callee.object.callee &&
164170
node.init.callee.object.callee.name === 'require' &&
165-
!_.isUndefined(node.init.callee.property) &&
166-
!_.isUndefined(node.init.callee.property.name));
171+
node.init.callee.property &&
172+
node.init.callee.property.name);
167173
},
168174
// isObjectExpression
169175
// ------------------
@@ -239,7 +245,13 @@
239245
},
240246
'init': {
241247
'type': 'Identifier',
242-
'name': publicAPI.normalizeModuleName((node.init['arguments'][0].value) || (node.init['arguments'][0].elements[0].value))
248+
'name': (function() {
249+
if(node.init && node.init['arguments'] && node.init['arguments'][0] && node.init['arguments'][0].elements && node.init['arguments'][0].elements[0]) {
250+
return publicAPI.normalizeModuleName(node.init['arguments'][0].elements[0].value);
251+
} else {
252+
return publicAPI.normalizeModuleName(node.init['arguments'][0].value);
253+
}
254+
}())
243255
}
244256
};
245257
} else if(publicAPI.isRequireMemberExpression(node)) {
@@ -481,7 +493,6 @@
481493
lineNumberObj[currentLineNumber] = true;
482494
});
483495
publicAPI.commentLineNumbers = lineNumberObj;
484-
console.log('publicAPI.commentLineNumbers', publicAPI.commentLineNumbers);
485496
}
486497
var moduleName,
487498
args,

0 commit comments

Comments
 (0)