-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageFormat::Rgb10a2ui uses inconsistent casing. #192
Comments
It doesn't help that the casing is wrong in the SPIR-V grammar JSON: |
By the way, shouldn't the |
Good question, I don't think so based on how these formats are cased in GLSL, you can see it's specified as |
Hmm, complicated. @XAMPPRocky are we looking at this from a Rust naming conventions or GLSL/SPIR-V naming perspective? That link implies the entire thing to be lowercase while the autogenerator here seems to take the grammar name verbatim. |
Notice how
ImageFormat::Rgb10A2
andImageFormat::Rgb10a2ui
have a differently casedA
, in Rust the casing starts at the beginning of each word. The former is correct andRgb10a2ui
should beRgb10A2ui
.The text was updated successfully, but these errors were encountered: