Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. bug: missing chat-template support in llama-run #11178

Open
engelmi opened this issue Jan 10, 2025 · 1 comment
Open

Misc. bug: missing chat-template support in llama-run #11178

engelmi opened this issue Jan 10, 2025 · 1 comment

Comments

@engelmi
Copy link

engelmi commented Jan 10, 2025

Name and Version

$ llama-cli --version
version: 4460 (ba8a1f9)
built with cc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0 for x86_64-linux-gnu

Operating systems

Linux

Which llama.cpp modules do you know to be affected?

Other (Please specify in the next section)

Command line

llama-run granite-code

Problem description & steps to reproduce

The llama-run CLI currently doesn't take the chat template of a model into account. Thus executing llama-run on a model requiring such a template will fail.

First Bad Commit

No response

Relevant log output

failed to apply the chat template
@engelmi
Copy link
Author

engelmi commented Jan 10, 2025

One possible solution could be to extend llama-run so that it implicitly searches for a <model-name>.ollama.template and applies it via common_chat_apply_template - or directly downloads and saves it together with the model with the mentioned name pattern (if build with LLAMA_USE_CURL). In addition, another CLI option such as --chat-template could be added to not rely on an implicit naming convention (and template location).

Although it might take me a while, I'd be up for implementing this - if it makes sense, of course.

@engelmi engelmi changed the title Misc. bug: Misc. bug: missing chat-template support in llama-run Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant