-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Eval bug: Jinja not replacing date_string
#12729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Well, technically it can't because there's no (simple) way of passing variables. This variable in particular though should be replaced with the strftime_now function in the template. If that hasn't already happened in the official Llama 3.3 repo you can export the chat template (using scripts/get_chat_template.py f.ex.) and then load a modified copy using |
@ochafik WDYT, is this something that can/will be supported? AFAIK the only other use-cases for variables is RAG ( |
@CISC Ah, absolutely, I'll look into it. I want the time to be overridable by flag (for tests) & synced w/ the strftime_now minja function.
Seems it could definitely be useful (mostly for Cohere & Granite models AFAICT, with the latter ignoring the doc title).
Which granite model are you looking at, btw? (ibm-granite/granite-3.1-8b-instruct has no Allowing arbitrary values to be passed through to jinja may require more thinking, I reckon we'll want to only allow these specific ones. |
The ibm-granite/granite-3.2-8b-instruct has these, there doesn't really need to be a standard as
Makes sense. |
But minja https://docs.python.org/3/library/datetime.html#strftime-and-strptime-format-codes |
@wqerrewetw it should work (it's defined in |
Name and Version
Operating systems
Linux
GGML backends
CUDA
Hardware
AMD EPYC 7742 64-Core Processor + A800-SXM4-80GB
Models
No response
Problem description & steps to reproduce
Compile llama.cpp from source and run it with
~/llama.cpp/build/bin/llama-server -m /models/Llama-3.3-70B-Instruct-Q8_0.gguf --port 8000 -t 8 -ngl 81 -c 15360 --jinja
First Bad Commit
No response
Relevant log output
The text was updated successfully, but these errors were encountered: