Merge pull request #159 from RobertJansen1/pin_yaml

v4.2

Author: RobertJansen1

README.md

@@ -13,7 +13,7 @@ Create a new device within ESPHome builder and combine the yaml with one of the
 # MHI-AC-Ctrl-ESPHome
 This project is a simple integration of the amazing work [absalom-muc](https://github.com/absalom-muc) has done with his project [MHI-AC-Ctrl](https://github.com/absalom-muc/MHI-AC-Ctrl).\
 It's supposed to simplify the [Home Assistant](https://www.home-assistant.io/) setup, while giving you OTA and auto-discovery with virtually zero effort and no MQTT needed, powered by [ESPHome](https://ESPHome.io/).\
-`MHI-AC-Ctrl-core.*` files were forked directly, with no modification, whereas your WiFi credentials should go into the `*.yaml` file, and `mhi_ac_ctrl.h` is the core of the integration.
+`MHI-AC-Ctrl-core.*` files were forked directly, with a small modification to allow for pin setting in yaml, whereas your WiFi credentials should go into the `*.yaml` file, and `mhi_ac_ctrl.h` is the core of the integration.
 
 # Fan Modes Up/Down Left/Right
 Most newer MHI units (the ones supporting the WF-RAC WiFi module) support fine grained vane control for Left/Right and Up/Down.  
@@ -52,13 +52,18 @@ This will allow for lower temperature heating or cooling.
 # Changelog:
 
 
+**v4.2** (2025-07)
+ - Allow configuration of pins through yaml
+ - Update calculation of Indoor Heat exchanger temperature 2 (capillary)
+ - Don't spam unit with unchanged room_temp
+ - **Deprecating set set_vertical_vanes and set_horizontal_vanes, will be removed in v4.3 use select functions for fan control**
 
 **v4.1** (2025-07)
  - Changed climate.CLIMATE_SCHEMA to fix deprecation warning in 2025.5.0 and higher https://github.com/ginkage/MHI-AC-Ctrl-ESPHome/issues/151
  - Make 0.5 degrees setpoint actually work https://github.com/ginkage/MHI-AC-Ctrl-ESPHome/issues/88
  - Allow low temp heating and cooling (below 18 degrees) https://github.com/ginkage/MHI-AC-Ctrl-ESPHome/issues/152
- - Allow fan speed from ESPHome web interface https://github.com/ginkage/MHI-AC-Ctrl-ESPHome/issues/136
- - Deprecating set set_vertical_vanes and set_horizontal_vanes, will be removed in v4.2 use select functions for fan control
+ - Allow fan speed from esphome web interface https://github.com/ginkage/MHI-AC-Ctrl-ESPHome/issues/136
+ - Deprecating set set_vertical_vanes and set_horizontal_vanes, will be removed in v4.3 use select functions for fan control
 
 **v4.0** (2025-04)
  - Compatibility with ESPHOME 2025.2+

components/MhiAcCtrl/MHI-AC-Ctrl-core.h

@@ -31,10 +31,11 @@ const byte opdata[][2] PROGMEM = {
 #define NoFramesPerOpDataCycle 400             // number of frames used for a OpData request cycle; will be 20s (20 frames are 1s)
 #define minTimeInternalTroom 5000              // minimal time in ms used for Troom internal sensor changes for publishing to avoid jitter 
 
-// pin defintions
-#define SCK_PIN  14
-#define MOSI_PIN 13
-#define MISO_PIN 12
+// Declare extern variables for the pins the only change to the original code
+// This allows to set the pins in the configuration file
+extern int SCK_PIN;
+extern int MOSI_PIN;
+extern int MISO_PIN;
 
 // constants for the frame
 #define SB0 0

components/MhiAcCtrl/__init__.py

@@ -9,6 +9,9 @@
 CONF_ROOM_TEMP_TIMEOUT = 'room_temp_timeout'
 CONF_VANES_UD = 'initial_vertical_vanes_position'
 CONF_VANES_LR = 'initial_horizontal_vanes_position'
+CONF_SCK_PIN = "sck_pin"
+CONF_MOSI_PIN = "mosi_pin"
+CONF_MISO_PIN = "miso_pin"
 
 CONF_VANES_POSITION = 'position'
 CONF_TEMPERATURE = 'temperature'
@@ -28,6 +31,9 @@
     cv.Optional(CONF_ROOM_TEMP_TIMEOUT, default=60): cv.int_range(min=0, max=3600),
     cv.Optional(CONF_VANES_UD): cv.int_range(min=0, max=5),
     cv.Optional(CONF_VANES_LR): cv.int_range(min=0, max=8),
+    cv.Optional(CONF_SCK_PIN): cv.int_,
+    cv.Optional(CONF_MOSI_PIN): cv.int_,
+    cv.Optional(CONF_MISO_PIN): cv.int_,
 }).extend(cv.COMPONENT_SCHEMA)
 
 async def to_code(config):
@@ -42,7 +48,12 @@ async def to_code(config):
         cg.add(var.set_vanes(config[CONF_VANES_UD]))
     if CONF_VANES_LR in config:
         cg.add(var.set_vanesLR(config[CONF_VANES_LR]))
-
+    if CONF_SCK_PIN in config:
+        cg.add(var.set_sck_pin(config[CONF_SCK_PIN]))
+    if CONF_MOSI_PIN in config:
+        cg.add(var.set_mosi_pin(config[CONF_MOSI_PIN]))
+    if CONF_MISO_PIN in config:
+        cg.add(var.set_miso_pin(config[CONF_MISO_PIN]))
 
 @automation.register_action(
     "climate.mhi.set_vertical_vanes",

components/MhiAcCtrl/mhi_platform.cpp

@@ -1,12 +1,26 @@
 #include "mhi_platform.h"
 
+int SCK_PIN = 14;
+int MOSI_PIN = 13;
+int MISO_PIN = 12;
 namespace esphome {
 namespace mhi {
 
 static const char* TAG = "mhi.platform";
 
+
 void MhiPlatform::setup() {
 
+    if (this->sck_pin_ >= 0) { //
+      SCK_PIN = this->sck_pin_;
+    }
+    if (this->mosi_pin_ >= 0) { //
+      MOSI_PIN = this->mosi_pin_;
+    }
+    if (this->miso_pin_ >= 0) { //
+      MISO_PIN = this->miso_pin_;
+    }
+
     this->mhi_ac_ctrl_core_.MHIAcCtrlStatus(this);
     this->mhi_ac_ctrl_core_.init();
     this->mhi_ac_ctrl_core_.set_frame_size(this->frame_size_); // set framesize. Only 20 (legacy) or 33 (includes 3D auto and vertical vanes) possible
@@ -78,12 +92,22 @@ void MhiPlatform::set_room_temperature(float value) {
 
 void MhiPlatform::transfer_room_temperature(float value) {
     if (isnan(value)) {
-        mhi_ac_ctrl_core_.set_troom(0xff); // reset target, use internal sensor
+        if (!isnan(this->last_room_temperature_)) {
+            ESP_LOGD(TAG, "set room_temp_api: value is NaN, using internal sensor");
+            mhi_ac_ctrl_core_.set_troom(0xff); // reset target, use internal sensor
+            this->last_room_temperature_ = NAN; // reset last room temperature
+        }
+        return;
+    }
+
+    if (fabs(value - last_room_temperature_) < 0.01) {
+        return;
     }
 
     if ((value > -10) & (value < 48)) {
         byte tmp = value * 4 + 61;
-        this->mhi_ac_ctrl_core_.set_troom(value * 4 + 61);        
+        this->mhi_ac_ctrl_core_.set_troom(value * 4 + 61);
+        this->last_room_temperature_ = value; // store last room temperature
         ESP_LOGD(TAG, "set room_temp_api: %f %i %i", value, (byte)(value * 4 + 61), (byte)tmp);
     }
 }

components/MhiAcCtrl/mhi_platform.h

@@ -34,16 +34,23 @@ class MhiPlatform :
     void set_vanesLR(int value);
     void set_3Dauto(bool value);
     void set_external_room_temperature_sensor(sensor::Sensor* sensor);
+    void set_sck_pin(int pin) { this->sck_pin_ = pin; };
+    void set_mosi_pin(int pin) { this->mosi_pin_ = pin; };
+    void set_miso_pin(int pin) { this->miso_pin_ = pin; };
     void add_listener(MhiStatusListener* listener);
 
 
 private:
     void transfer_room_temperature(float value);
+    float last_room_temperature_ = NAN; 
 
     int frame_size_;
     unsigned long room_temp_api_timeout_start_ = millis();
     unsigned long room_temp_api_timeout_;
     bool room_temp_api_active_ = false;
+    int sck_pin_ = -1;
+    int mosi_pin_ = -1;
+    int miso_pin_ = -1;
 
     MHI_AC_Ctrl_Core mhi_ac_ctrl_core_;
 

components/MhiAcCtrl/sensor/mhi_sensors.cpp

@@ -138,9 +138,11 @@ void MhiSensors::update_status(ACStatus status, int value) {
         // output_P(status, PSTR(TOPIC_THI_R1), strtmp);
         break;
     case opdata_thi_r2:
-        // Indoor Heat exchanger temperature 2 (capillary)
+        // Indoor Heat exchanger temperature 2 (capillary) 
+        // 2025-07-08: Renewed calculation, needs to be confirmed
+        // previously it was 0.327f * value - 11.4f, which is not correct
         if (this->indoor_unit_thi_r2_ != NULL) { 
-            this->indoor_unit_thi_r2_ -> publish_state(0.327f * value - 11.4f); 
+            this->indoor_unit_thi_r2_ -> publish_state(0.275f * value - 47.0f); 
         }
         break;
     case erropdata_thi_r2:

examples/full.yaml

@@ -45,12 +45,15 @@ api:
         - climate.mhi.set_external_room_temperature:
             temperature: !lambda "return temperature_value;"
 
-# Version 4.1
+# Version 4.2
 
 MhiAcCtrl:
   # Only 20 (legacy) or 33 (includes 3D auto and vertical vanes) possible.
   # If you encounter mhi_ac_ctrl_core.loop error: -2 errors, change the frame_size to 20
   frame_size: 33
+  sck_pin: 14
+  mosi_pin: 13
+  miso_pin: 12
   initial_vertical_vanes_position: 5
   initial_horizontal_vanes_position: 8
   # Update the following to change the default room temp timeout