Thanks for the incognito tip @RJVB !! I was able to debug further and found a fix to make unsuspending work.

Fix is to remove the key-value pair autoDiscardable: false from the unsuspendTab function in background.js. Its at line 631 in the original repo and 624 in this one. Apparently the update function here in Firefox doesnt take autoDiscardable as a valid key. This is enough to make unsuspending work but I cant say if it breaks something else. So far everything looks fine for me.

Although unsuspending in incognito mode still doesnt work. There is an issue with calling chrome.extension.getBackgroundPage() (in popup.js, line 5) in Firefox when using incognito mode. When in incognito the function returns a null which causes an error and the script stops. The issue is detailed more here. From what I have read here it seems like there is a fix for this but would require a lot of changes/testing. I will try and see if there is a simple change for this but not keeping my hopes up there.

Regardless, it works well enough now for my needs :) Do note, this is tested with the v7.1.6 (last non malicious release) of original TGS and on Firefox Developer Edition v91.0b8. Had to use Developer edition since normal FF doesnt allow installing unsigned addons; and with the how Chrome Store Foxified is going on I dont think it would be possible to easily get signed xpis.

Uh oh!

(Feature Request) Firefox version of Marvellous Suspender #18

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions