Skip to content

Pause for forms with input most likely broken. #242

Open
@RJVB

Description

@RJVB

The TMS extension on my ChromeTab does not react to typing input into a form the way it is intended to AFAICT, that is like in this screenshot of a fixed version of @dvalter's version for firefox:
image

I see 2 reasons and a more general issue:

if (event.keyCode >= 48 && event.keyCode <= 90 && event.target.tagName) {

1- the event variable isn't defined; easily fixed by renaming the e argument to event
2- the keyCode property has been deprecated for quite some time
3- the code only checks for inputs in the range '0' to 'Z', basically the 10 digits and uppercase Roman letters.

The latter 2 can be fixed by changing the range check to

event.key >= "0" && event.key <= "z"

See https://github.com/dvalter/ff-thegreatsuspender/pull/7/files

The Firefox version is based on an older fork of the original TGS and also has an issue-by-design where emptying the form doesn't unpause the extension. I haven't yet figured that one out and thus also not if that aspect has been fixed in this TMS version.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions