Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto choose download package on website based on user OS. #7772

Open
mrtechtroid opened this issue Mar 22, 2025 · 3 comments · May be fixed by #7824
Open

Auto choose download package on website based on user OS. #7772

mrtechtroid opened this issue Mar 22, 2025 · 3 comments · May be fixed by #7824
Labels
enhancement An improvement to an existing feature @gitbutler/web help wanted We would love you to get involved.

Comments

@mrtechtroid
Copy link

Hi, I was just checking out GitButler for the first time. I downloaded it assuming it would be set for Windows, but saw it downloaded the dmg. I noticed that by default Apple is selected for the download button.

Instead it would be great if it was changed such that if the default OS being chosen is based on the Client visiting the website. (By default people tend to assume, that the website would give the OS appropriate version for the default download)

Thanks!

(I think the tag would be @gitbutler/website?)
@wleklinskimateusz
Copy link

I'm also new to GitButler, and thought about the same thing, if you're open to external contributors, I can make a PR for this issue

@Byron Byron added enhancement An improvement to an existing feature help wanted We would love you to get involved. @gitbutler/web labels Mar 23, 2025
@Byron
Copy link
Collaborator

Byron commented Mar 23, 2025 •
edited
Loading

Thanks for reporting, and setting the default to what's appropriate for the OS seems very reasonable.

Whenever there is multiple options for the platform, I wonder if it's possible to make a decision based on what likely will be the user-agent string. For instance, is it possible to tell Apple Silicon apart from Intel?
Also, on Linux, there is a presumably impossible choice between different kinds of packages.

In any case, differentiating broadly already seems like an improvement.

@wleklinskimateusz A PR would definitely be welcome, thanks for offering.

@wleklinskimateusz
Copy link

regarding the Intel vs Apple Silicon it seems to be possible but the support for this may be limited to newer browsers, I'll check it out and try to test on various platforms

@wleklinskimateusz wleklinskimateusz linked a pull request Mar 25, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An improvement to an existing feature @gitbutler/web help wanted We would love you to get involved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: auto detect system os to download correct target wleklinskimateusz/gitbutler
3 participants
@Byron @wleklinskimateusz @mrtechtroid