Skip to content
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.

Add build step #13

Open
mike182uk opened this issue Jan 11, 2016 · 8 comments
Open

Add build step #13

mike182uk opened this issue Jan 11, 2016 · 8 comments

Comments

@mike182uk
Copy link
Contributor

We should consider having a build step that does things like check code-style, runs tests etc. and provides feedback on new pull requests.

@PatrickHeneise
Copy link
Member

code-style can be checked by hound, tests by codeship etc. Most of the services run on the core already, we can just include the plugin repos?

@iancrowther
Copy link
Contributor

@mike182uk - please check out http://jscs.info/

@iancrowther
Copy link
Contributor

eslint also

@mike182uk
Copy link
Contributor Author

Yep i am aware of these tools, the issue was more aimed at using CI to run these things automatically on a new PR. Hound and Codeship would work, and if they are already in use on core then it shouldn't be too difficult to integrate them into this.

@iancrowther
Copy link
Contributor

Can switch on, do you have permissions

@PatrickHeneise
Copy link
Member

hound currently runs an old version of jshint. We could turn hint off and use jscs only?

@iancrowther
Copy link
Contributor

happy to go that route

@PatrickHeneise
Copy link
Member

Just tried it in a recent project, unfortunately jscs really does only code style and doesn't tell you about important JS issues like jshint does.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants