This repository has been archived by the owner on Sep 23, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Add build step #13
Comments
code-style can be checked by hound, tests by codeship etc. Most of the services run on the core already, we can just include the plugin repos? |
@mike182uk - please check out http://jscs.info/ |
eslint also |
Yep i am aware of these tools, the issue was more aimed at using CI to run these things automatically on a new PR. Hound and Codeship would work, and if they are already in use on core then it shouldn't be too difficult to integrate them into this. |
Can switch on, do you have permissions |
hound currently runs an old version of jshint. We could turn hint off and use jscs only? |
happy to go that route |
Just tried it in a recent project, unfortunately jscs really does only code style and doesn't tell you about important JS issues like jshint does. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We should consider having a build step that does things like check code-style, runs tests etc. and provides feedback on new pull requests.
The text was updated successfully, but these errors were encountered: