-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outdated vlab gen default values #294
Comments
Fixes #294 Signed-off-by: Pau Capdevila <[email protected]>
I was looking at the cause of the CI failure:
I found where the defaults are actually hardcoded:
@Frostman, I know this PR is very low value. When you can, please comment if you think it's worth progressing it The hhfab defaults are focused on the spine-leaf case. We could set FabricLinksCount to 0 if CollapsedCore |
@pau-hedgehog I've responded partially on PR - I think it just needs a rework, we've been discussing it a few times with Logan before and I think it overlaps with making default VLAB setup work nicely for laptops, I'll take a look on what needs to be changed |
According to:
Some default values in the
vlab gen
help seem outdated:Observed in Beta1:
The text was updated successfully, but these errors were encountered: