Skip to content

Commit 5e994c3

Browse files
committed
Don't fail post start-proxy action if killing the proxy process fails
Otherwise logs won't get uploaded as artifact, even in debug mode
1 parent 082a88e commit 5e994c3

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

lib/start-proxy-action-post.js

+6-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/start-proxy-action-post.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/start-proxy-action-post.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,11 @@ async function runWrapper() {
2222
// Kill the running proxy
2323
const pid = core.getState("proxy-process-pid");
2424
if (pid) {
25-
process.kill(Number(pid));
25+
try {
26+
process.kill(Number(pid));
27+
} catch (error) {
28+
logger.error(`Failed to kill proxy process: ${getErrorMessage(error)}`);
29+
}
2630
}
2731

2832
const config = await configUtils.getConfig(

0 commit comments

Comments
 (0)