Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Handling Issue When Suborg Level Parameters Reference Non-Existent Teams #675

Open
syakovenko81 opened this issue Sep 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@syakovenko81
Copy link

When changing a parameter at the suborg level, such as suborgteams, to a non-existent team, the system returns an unexpected value.

# List of repos that belong to the suborg
suborgrepos:
  - test-repos*
# You can use Glob patterns

suborgteams:
  - test-team

image

The pod logs indicate an HttpError: Not Found error, which is logged as:

{"level":50,"time":1725518921172,"pid":25,"hostname":"safe-settings-c687bc859-x9c5d","name":"probot","name":"probot","name":"event","id":"e0970a60-6b52-11ef-9f7d-55142efd27bc","msg":"NOPCOMMAND {\"type\":\"ERROR\",\"plugin\":\"getSubOrgConfigs\",\"repo\":\"safe-settings\",\"endpoint\":\"\",\"body\":\"\",\"action\":{\"msg\":\"HttpError: Not Found\",\"additions\":null,\"modifications\":null,\"deletions\":null}}"}

We used release 2.1.10, but the issue also occurs in versions 2.1.11 and 2.1.12-rc.1.

@syakovenko81 syakovenko81 added the bug Something isn't working label Sep 5, 2024
@decyjphr
Copy link
Collaborator

decyjphr commented Sep 6, 2024

Thanks for reporting. I'll look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants