Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow opening file instead of diff #1651

Open
rryk opened this issue Sep 22, 2021 · 7 comments · May be fixed by #2845 or #3583
Open

Allow opening file instead of diff #1651

rryk opened this issue Sep 22, 2021 · 7 comments · May be fixed by #2845 or #3583
Labels
feature New feature or request good first issue Good for newcomers help wanted Want community input and/or pull request
Milestone

Comments

@rryk
Copy link

rryk commented Sep 22, 2021

When clicking on the filename in "Search & Compare", it opens a diff by default. To open the file itself one needs to right-click and select "Open File". Would be nice to have a setting to open files by default. This is similar to microsoft/vscode#36885, but for GitLens panels.

@rryk rryk added feature New feature or request triage Needs to be looked at labels Sep 22, 2021
@gspencergoog
Copy link

This is the default behavior for Gitscope on IntellliJ, and I find it to be incredibly helpful there. It lets me use the current list of diffs from the main branch as a workspace that contains only the files I'm working on for the current change. With the need to click on a small icon to open the file instead of the diff, it makes me think about opening a file more carefully, and slows me down.

@eamodio eamodio removed the triage Needs to be looked at label Dec 22, 2021
@eamodio eamodio added this to the Soonish™ milestone Dec 22, 2021
@eamodio
Copy link
Member

eamodio commented Dec 22, 2021

Sounds like a good enhancement. Thanks!

@gspencergoog
Copy link

The VSCode git extension has an option called "git.openDiffOnClick" that does exactly what this feature request describes. It would be nice if GitLens had this too.

@eamodio eamodio added help wanted Want community input and/or pull request good first issue Good for newcomers labels Aug 9, 2022
@marcoapcaldas
Copy link

Is this option inline sufficient for this feature?

image

@gspencergoog
Copy link

@marcoapcaldas No, because it's about the default: both the diff and the file icons are available, but the diff is the default when you click on it, and I'd much prefer it be the file. I'm constantly accidentally opening the diff window, immediately closing it, and then having to focus to click the tiny file icon, which takes me out of my flow.

@marcoapcaldas
Copy link

I'm trying to find which files I should work on to make this feature, but I hadn't sucess. Could you give me some tips @eamodio ?

Svaught598 added a commit to Svaught598/vscode-gitlens that referenced this issue Aug 5, 2023
@Svaught598 Svaught598 linked a pull request Aug 5, 2023 that will close this issue
7 tasks
@EhabY
Copy link

EhabY commented Sep 18, 2024

Given that the old PR is more than a year old, I have submitted another PR to fix this issue #3583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Want community input and/or pull request
Projects
None yet
5 participants