Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds filter button to graph search box #3686

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Adds filter button to graph search box #3686

merged 2 commits into from
Oct 21, 2024

Conversation

axosoft-ramint
Copy link
Contributor

Having the button enabled allows you to filter when searching the graph.

Requires this PR merged as a pre-requisite, and dependency updated, before it can leave draft: https://github.com/gitkraken/GitKrakenComponents/pull/359

@axosoft-ramint axosoft-ramint added area-graph Issues or features related to the commit graph feature New feature or request labels Oct 18, 2024
@axosoft-ramint axosoft-ramint marked this pull request as ready for review October 21, 2024 16:58
@axosoft-ramint
Copy link
Contributor Author

@eamodio @d13 The dependency is now merged and this is ready to review/merge.

d13
d13 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@d13 d13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Though we might want to remember the toggle state.

@axosoft-ramint axosoft-ramint merged commit f43688f into main Oct 21, 2024
3 checks passed
@axosoft-ramint axosoft-ramint deleted the feature/graph-filter-search branch October 21, 2024 22:56
@d13 d13 linked an issue Nov 4, 2024 that may be closed by this pull request
Remove the filtered out commits in commits graph #3710
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d13 d13 d13 approved these changes

@eamodio eamodio Awaiting requested review from eamodio

Assignees

@d13 d13

@eamodio eamodio

Labels
area-graph Issues or features related to the commit graph feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the filtered out commits in commits graph
3 participants
@axosoft-ramint @d13 @eamodio