Skip to content

Commit 1063a80

Browse files
committed
fix: eslint unused vars
1 parent e5ab47f commit 1063a80

File tree

2 files changed

+15
-22
lines changed

2 files changed

+15
-22
lines changed

apps/frontend/src/components/media/media.component.tsx

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { FC, useCallback, useEffect, useState } from 'react';
44
import { Button } from '@gitroom/react/form/button';
55
import { useMediaDirectory } from '@gitroom/react/helpers/use.media.directory';
66
import { useSettings } from '@gitroom/frontend/components/launches/helpers/use.values';
7-
import EventEmitter from 'events';
87
import dynamic from 'next/dynamic';
98
import { useUser } from '@gitroom/frontend/components/layout/user.context';
109
import { MediaBox } from './mediabox.component';
@@ -28,17 +27,19 @@ export const MediaComponent: FC<{
2827
const { name, type, label, description, onChange, value, width, height } = props;
2928
const { getValues } = useSettings();
3029
const user = useUser();
30+
31+
const [modal, setShowModal] = useState(false);
32+
const [mediaModal, setMediaModal] = useState(false);
33+
const [currentMedia, setCurrentMedia] = useState(value);
34+
const mediaDirectory = useMediaDirectory();
35+
3136
useEffect(() => {
3237
const settings = getValues()[props.name];
3338
if (settings) {
3439
setCurrentMedia(settings);
3540
}
3641
}, []);
37-
const [modal, setShowModal] = useState(false);
38-
const [mediaModal, setMediaModal] = useState(false);
39-
const [currentMedia, setCurrentMedia] = useState(value);
40-
const mediaDirectory = useMediaDirectory();
41-
42+
4243
const closeDesignModal = useCallback(() => {
4344
setMediaModal(false);
4445
}, [modal]);

apps/frontend/src/components/media/multimedia.component.tsx

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -17,27 +17,20 @@ export const MultiMediaComponent: FC<{
1717
target: { name: string; value?: Array<{ id: string; path: string }> };
1818
}) => void;
1919
}> = (props) => {
20-
const { name, label, error, description, onChange, value } = props;
20+
const { name, error, onChange, value } = props;
2121
const user = useUser();
22-
useEffect(() => {
23-
if (value) {
24-
setCurrentMedia(value);
25-
}
26-
}, []);
2722

2823
const [modal, setShowModal] = useState(false);
2924
const [mediaModal, setMediaModal] = useState(false);
30-
31-
const [currentMedia, setCurrentMedia] = useState(value);
25+
3226
const mediaDirectory = useMediaDirectory();
3327

3428
const changeMedia = useCallback(
3529
(m: { path: string; id: string }) => {
36-
const newMedia = [...(currentMedia || []), m];
37-
setCurrentMedia(newMedia);
30+
const newMedia = [...(value || []), m];
3831
onChange({ target: { name, value: newMedia } });
3932
},
40-
[currentMedia, name]
33+
[value, name]
4134
);
4235

4336
const showModal = useCallback(() => {
@@ -50,11 +43,10 @@ export const MultiMediaComponent: FC<{
5043

5144
const clearMedia = useCallback(
5245
(topIndex: number) => () => {
53-
const newMedia = currentMedia?.filter((f: any, index: number) => index !== topIndex);
54-
setCurrentMedia(newMedia);
46+
const newMedia = value?.filter((f: any, index: number) => index !== topIndex);
5547
onChange({ target: { name, value: newMedia } });
5648
},
57-
[currentMedia]
49+
[value]
5850
);
5951

6052
const designMedia = useCallback(() => {
@@ -114,8 +106,8 @@ export const MultiMediaComponent: FC<{
114106
</Button>
115107
</div>
116108

117-
{!!currentMedia &&
118-
currentMedia.map((media: { path: string ; }, index: number) => (
109+
{!!value &&
110+
value.map((media: { path: string ; }, index: number) => (
119111
<>
120112
<div className="cursor-pointer w-[40px] h-[40px] border-2 border-tableBorder relative flex">
121113
<div

0 commit comments

Comments
 (0)