bluesky handle checking updated to be on the server side + pull from bluesky official app

Author: divyaswormakai

libraries/helpers/src/integrations/bluesky.provider.ts

@@ -0,0 +1,92 @@
+// Source:https://github.com/bluesky-social/atproto/blob/main/packages/syntax/src/handle.ts
+
+// Handle constraints, in English:
+//  - must be a possible domain name
+//    - RFC-1035 is commonly referenced, but has been updated. eg, RFC-3696,
+//      section 2. and RFC-3986, section 3. can now have leading numbers (eg,
+//      4chan.org)
+//    - "labels" (sub-names) are made of ASCII letters, digits, hyphens
+//    - can not start or end with a hyphen
+//    - TLD (last component) should not start with a digit
+//    - can't end with a hyphen (can end with digit)
+//    - each segment must be between 1 and 63 characters (not including any periods)
+//    - overall length can't be more than 253 characters
+//    - separated by (ASCII) periods; does not start or end with period
+//    - case insensitive
+//    - domains (handles) are equal if they are the same lower-case
+//    - punycode allowed for internationalization
+//  - no whitespace, null bytes, joining chars, etc
+//  - does not validate whether domain or TLD exists, or is a reserved or
+//    special TLD (eg, .onion or .local)
+//  - does not validate punycode
+export const ensureValidHandle = (handle: string): void => {
+  // check that all chars are boring ASCII
+  if (!/^[a-zA-Z0-9.-]*$/.test(handle)) {
+    throw new Error(
+      'Disallowed characters in handle (ASCII letters, digits, dashes, periods only)'
+    );
+  }
+
+  if (handle.length > 253) {
+    throw new Error('Handle is too long (253 chars max)');
+  }
+  const labels = handle.split('.');
+  if (labels.length < 2) {
+    throw new Error('Handle domain needs at least two parts');
+  }
+  for (let i = 0; i < labels.length; i++) {
+    const l = labels[i];
+    if (l.length < 1) {
+      throw new Error('Handle parts can not be empty');
+    }
+    if (l.length > 63) {
+      throw new Error('Handle part too long (max 63 chars)');
+    }
+    if (l.endsWith('-') || l.startsWith('-')) {
+      throw new Error('Handle parts can not start or end with hyphens');
+    }
+    if (i + 1 === labels.length && !/^[a-zA-Z]/.test(l)) {
+      throw new Error(
+        'Handle final component (TLD) must start with ASCII letter'
+      );
+    }
+  }
+};
+
+// simple regex translation of above constraints
+export const ensureValidHandleRegex = (handle: string): void => {
+  if (
+    !/^([a-zA-Z0-9]([a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?\.)+[a-zA-Z]([a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?$/.test(
+      handle
+    )
+  ) {
+    throw new Error("Handle didn't validate via regex");
+  }
+  if (handle.length > 253) {
+    throw new Error('Handle is too long (253 chars max)');
+  }
+};
+
+export const normalizeHandle = (handle: string): string => {
+  return handle.toLowerCase();
+};
+
+export const normalizeAndEnsureValidHandle = (handle: string): string => {
+  const normalized = normalizeHandle(handle);
+  ensureValidHandle(normalized);
+  return normalized;
+};
+
+export const isValidHandle = (handle: string): boolean => {
+  try {
+    ensureValidHandle(handle);
+  } catch (err) {
+    console.log('Error in bluesky handle validation:', err);
+    if (err instanceof Error) {
+      return false;
+    }
+    return false;
+  }
+
+  return true;
+};

libraries/nestjs-libraries/src/integrations/social/bluesky.provider.ts

@@ -11,6 +11,7 @@ import dayjs from 'dayjs';
 import { Integration } from '@prisma/client';
 import { AuthService } from '@gitroom/helpers/auth/auth.service';
 import sharp from 'sharp';
+import { isValidHandle } from '@gitroom/helpers/integrations/bluesky.provider';
 
 export class BlueskyProvider extends SocialAbstract implements SocialProvider {
   identifier = 'bluesky';
@@ -31,7 +32,7 @@ export class BlueskyProvider extends SocialAbstract implements SocialProvider {
         key: 'identifier',
         label: 'Identifier',
         placeholder: 'johndoe.bsky.social',
-        validation: `/^[a-zA-Z0-9]+\\.[a-zA-Z0-9]+\\.[a-zA-Z0-9]+$/`,
+        validation: `/^.{3,}$/`,
         type: 'text' as const,
       },
       {
@@ -76,6 +77,10 @@ export class BlueskyProvider extends SocialAbstract implements SocialProvider {
         service: body.service,
       });
 
+      if (!isValidHandle(body.identifier)) {
+        throw new Error('Invalid handle');
+      }
+
       const {
         data: { accessJwt, refreshJwt, handle, did },
       } = await agent.login({
@@ -97,7 +102,10 @@ export class BlueskyProvider extends SocialAbstract implements SocialProvider {
         username: profile.data.handle!,
       };
     } catch (error) {
-      console.error('Error occurred in the authenticate function:', error);
+      console.error(
+        'Error occurred in the +Bluesky authenticate function',
+        error
+      );
       return {
         refreshToken: '',
         expiresIn: 0,