-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll view scrolling not working in side the <GestureRecognizer> #72
Comments
Hi @Anunest have you got any solution for this issue? |
@amartyach98 If you still want this fixed, you could try and install my forked repo via |
I have got mine working inside of a ScrollView just fine, anything in particular that caused your issue? |
Here is the diff that solved my problem: diff --git a/node_modules/react-native-swipe-gestures/index.js b/node_modules/react-native-swipe-gestures/index.js
index 38d1db5..fd94b51 100644
--- a/node_modules/react-native-swipe-gestures/index.js
+++ b/node_modules/react-native-swipe-gestures/index.js
@@ -58,8 +58,8 @@ class GestureRecognizer extends Component {
_gestureIsClick(gestureState) {
return (
- Math.abs(gestureState.dx) < swipeConfig.gestureIsClickThreshold &&
- Math.abs(gestureState.dy) < swipeConfig.gestureIsClickThreshold
+ Math.abs(gestureState.dx) < swipeConfig.gestureIsClickThreshold
+ //&& Math.abs(gestureState.dy) < swipeConfig.gestureIsClickThreshold
);
}
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: