-
Notifications
You must be signed in to change notification settings - Fork 190
Open
Description
I see the error Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node popping up in sentry from time to time. I have yet to reproduce it when I try, but I know it freezes the whole UI when it happens.
It is not a very viable solution to tell users to uninstall various chrome extensions and/or not use google translate in order to not break a glimmer app. This has occurred both on Chrome and Edge.
Is it possible with a more resilient handling in clearElement?
glimmer-vm/packages/@glimmer/util/lib/dom.ts
Lines 4 to 12 in 4f1bef0
| export function clearElement(parent: SimpleElement) { | |
| let current: Option<SimpleNode> = parent.firstChild; | |
| while (current) { | |
| let next = current.nextSibling; | |
| parent.removeChild(current); | |
| current = next; | |
| } | |
| } |
Perhaps a try-catch? Or will that disturb some other inner workings?
apellerano-pw, shama, VincentMolinie and artemgurzhii
Metadata
Metadata
Assignees
Labels
No labels
