Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageGLView.data is a Float64Array which WebGL does not support #63

Open
pllim opened this issue Jul 15, 2021 · 3 comments
Open

ImageGLView.data is a Float64Array which WebGL does not support #63

pllim opened this issue Jul 15, 2021 · 3 comments

Comments

@pllim
Copy link
Contributor

pllim commented Jul 15, 2021

Loading an astronomical image into Imviz in Jdaviz triggers this, as noticed by @rosteen . Not sure where the fix should be.

} else if(data instanceof Float64Array) {
console.warn('ImageGLView.data is a Float64Array which WebGL does not support, will convert to a Float32Array (consider sending float32 data for better performance).');
data = Float32Array.from(data);
type = THREE.FloatType;

@pllim
Copy link
Contributor Author

pllim commented Jul 15, 2021

@mwcraig
Copy link
Contributor

mwcraig commented Jul 15, 2021

I think the fix is to convert the data to float32 on the python side before sending the data to glue and friends...

@mwcraig
Copy link
Contributor

mwcraig commented Jul 15, 2021

Actually, maybe that isn't it....I see this if I create an image mark without any data. Setting the data later doesn't seem to generate a complaint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants