Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can RandomBeansExtension be updated to renamed Easy Random #14

Open
maccamlcQ opened this issue Jul 18, 2019 · 5 comments
Open

Can RandomBeansExtension be updated to renamed Easy Random #14

maccamlcQ opened this issue Jul 18, 2019 · 5 comments

Comments

@maccamlcQ
Copy link

RandomBeans seems to have been updated to https://github.com/j-easy/easy-random

@glytching
Copy link
Owner

@maccamlcQ thanks for raising this issue. The extension provides an abstraction over the underlying 'random provider' so renaming the extension in response to a rename of the underlying provider might defeat the purpose (or one of the purposes, at least) of the abstraction. That said, I have named the abstraction in such a way that it makes clear what underlying provider is at play i.e. by naming is XXXExtension I have made clear the association with XXX. The intention there was to underline the association - for ease of use - for people who were already using RandomBeans. So now I'm in two minds:

  • Accept that the extension is an abstraction but with a name which strongly implies what it abstracts then rename the extension to EasyRandomExtension; this continues the approach I originally adopted but leaves the library open to being in this situation in future if EasyRandom changes its name again
  • Remove any reference to the underlying provider from the extension's name and let the docs (as they currently do) describe how to use the extension and what the extension is based on.

If I continue with the existing approach then I have to make a non back compatible change to the library and I am open to having to make future non back compatible changes to the library if/when an underlying library changes - this feels like a leak.

If I adopt the second option described above then I could make no changes - since RandomBeansExtension is already different to EasyBeans - other than updating the docs to acknowledge the change in the underlying provider's name. Though in that case users of junit-extensions might be left wondering "does the name RandomBeansExtension mean that the extension continues to use Random Beans from before its move to EasyRandom". So even adopting this approach could cause unwanted confusion.

So, I think I do need to make a change to ...

  • Properly decouple the name of that extension from the underlying provider so that the library is insulated from any future changes to the name of the underlying provider
  • Update the docs to show that the underlying provider is EasyRandom regardless of how the extension is named

Hope that makes sense.

@maccamlcQ
Copy link
Author

Hi, sorry for the late response. However option 2 does sound like a nice option, as decoupling the extension from the actual provider would definitely be a nice step.

@rfelgent
Copy link

rfelgent commented Sep 5, 2021

HI @glytching ,

any updates/decisions ?

My concerns are the outdated version of io.github.benas:random-beans which is eventually forked from j-easy/easy-random.

Maybe you could update at least from 3.7 to 3.9 of io.github.benas:random-beans ?

Best regards

@glytching
Copy link
Owner

HI @glytching ,

any updates/decisions ?

My concerns are the outdated version of io.github.benas:random-beans which is eventually forked from j-easy/easy-random.

Maybe you could update at least from 3.7 to 3.9 of io.github.benas:random-beans ?

Best regards

Hi @rfelgent I've published a v2.5.0 of the library, this version uses 3.9.0 of io.github.benas:random-beans.

@rfelgent
Copy link

Thank you very much @glytching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants