Skip to content

Commit cd6d5a6

Browse files
committed
remove dsp v1
This change adds a new apiversion "v1", which will remove all the dsp "v1" related fields, and also defaults to dsp "v2". The new apiversion is set as the stored version, however k8s will continue to serve v1alpha1, however it is deprecated. All tests are updated acordingly. Signed-off-by: Humair Khan <[email protected]>
1 parent ef30372 commit cd6d5a6

File tree

180 files changed

+3068
-6077
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

180 files changed

+3068
-6077
lines changed

.github/resources/dspa-lite/dspa.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
1+
apiVersion: datasciencepipelinesapplications.opendatahub.io/v1
22
kind: DataSciencePipelinesApplication
33
metadata:
44
name: test-dspa

README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ To understand how these components interact with each other please refer to the
285285
To deploy a standalone MariaDB metadata database (rather than providing your own database connection details), simply add a `mariaDB` item under the `spec.database` in your DSPA definition with an `deploy` key set to `true`. All other fields are defaultable/optional, see [All Fields DSPA Example](config/samples/v2/dspa-all-fields/dspa_all_fields.yaml) for full details. Note that this component is mutually exclusive with externally-provided databases (defined by `spec.database.externalDB`).
286286

287287
```yaml
288-
apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
288+
apiVersion: datasciencepipelinesapplications.opendatahub.io/v1
289289
kind: DataSciencePipelinesApplication
290290
metadata:
291291
name: sample
@@ -302,7 +302,7 @@ spec:
302302
To deploy a Minio Object Storage component (rather than providing your own object storage connection details), simply add a `minio` item under the `spec.objectStorage` in your DSPA definition with an `image` key set to a valid minio component container image. All other fields are defaultable/optional, see [All Fields DSPA Example](config/samples/v2/dspa-all-fields/dspa_all_fields.yaml) for full details. Note that this component is mutually exclusive with externally-provided object stores (defined by `spec.objectStorage.externalStorage`).
303303

304304
```yaml
305-
apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
305+
apiVersion: datasciencepipelinesapplications.opendatahub.io/v1
306306
kind: DataSciencePipelinesApplication
307307
metadata:
308308
name: sample
@@ -320,7 +320,7 @@ spec:
320320
To deploy the standalone DS Pipelines UI component, simply add a `spec.mlpipelineUI` item to your DSPA with an `image` key set to a valid ui component container image. All other fields are defaultable/optional, see [All Fields DSPA Example](config/samples/v2/dspa-all-fields/dspa_all_fields.yaml) for full details.
321321

322322
```yaml
323-
apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
323+
apiVersion: datasciencepipelinesapplications.opendatahub.io/v1
324324
kind: DataSciencePipelinesApplication
325325
metadata:
326326
name: sample
@@ -337,7 +337,7 @@ spec:
337337
To deploy the ML Metadata artifact linage/metadata component, simply add a `spec.mlmd` item to your DSPA with `deploy` set to `true`. All other fields are defaultable/optional, see [All Fields DSPA Example](config/samples/v2/dspa-all-fields/dspa_all_fields.yaml) for full details.
338338

339339
```yaml
340-
apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
340+
apiVersion: datasciencepipelinesapplications.opendatahub.io/v1
341341
kind: DataSciencePipelinesApplication
342342
metadata:
343343
name: sample

api/v1/dspipeline_types.go

+394
Large diffs are not rendered by default.

api/v1/groupversion_info.go

+36
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/*
2+
Copyright 2023.
3+
4+
Licensed under the Apache License, Version 2.0 (the "License");
5+
you may not use this file except in compliance with the License.
6+
You may obtain a copy of the License at
7+
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
10+
Unless required by applicable law or agreed to in writing, software
11+
distributed under the License is distributed on an "AS IS" BASIS,
12+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
See the License for the specific language governing permissions and
14+
limitations under the License.
15+
*/
16+
17+
// Package v1 contains API Schema definitions for the datasciencepipelinesapplications v1 API group
18+
// +kubebuilder:object:generate=true
19+
// +groupName=datasciencepipelinesapplications.opendatahub.io
20+
package v1
21+
22+
import (
23+
"k8s.io/apimachinery/pkg/runtime/schema"
24+
"sigs.k8s.io/controller-runtime/pkg/scheme"
25+
)
26+
27+
var (
28+
// GroupVersion is group version used to register these objects
29+
GroupVersion = schema.GroupVersion{Group: "datasciencepipelinesapplications.opendatahub.io", Version: "v1"}
30+
31+
// SchemeBuilder is used to add go types to the GroupVersionKind scheme
32+
SchemeBuilder = &scheme.Builder{GroupVersion: GroupVersion}
33+
34+
// AddToScheme adds the types in this group-version to the given scheme.
35+
AddToScheme = SchemeBuilder.AddToScheme
36+
)

0 commit comments

Comments
 (0)