-
Notifications
You must be signed in to change notification settings - Fork 67
Open
Description
We've been using this module for our Shopify module for some time and it's been great for us.
It appears the return type work in #129 may have caused issues in PHP 7.4. The graph
command throws the following:
ERROR [Emergency]: Uncaught TypeError: Return value of Osiset\BasicShopifyAPI\ResponseAccess::offsetGet() must be an instance of Osiset\BasicShopifyAPI\mixed, instance of Osiset\BasicShopifyAPI\ResponseAccess returned
IN GET dev/tasks/ShopifyImportTask
Line 67 in /Users/xxx/Sites/silverstripe-shopify/vendor/osiset/basic-shopify-api/src/ResponseAccess.php
Using v10.0.5 with PHP 7.4 works as expected. v10.0.6 with PHP 7.4 throws the error above. PHP 8.0 with v10.0.6 works as expected.
Metadata
Metadata
Assignees
Labels
No labels