Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmarks] Optimize benchmarks for the monorepo #3314

Open
zivkovicmilos opened this issue Dec 10, 2024 · 1 comment
Open

[benchmarks] Optimize benchmarks for the monorepo #3314

zivkovicmilos opened this issue Dec 10, 2024 · 1 comment
Assignees
Labels
🗺️good first issue🗺️ Ideal for newcomer contributors help wanted Want to contribute? We recommend these issues.

Comments

@zivkovicmilos
Copy link
Member

Description

This task concerns optimizing the existing benchmarks, fixing them, or writing completely new ones for parts of the monorepo, namely gno.land, gnovm, tm2 and misc.

Currently, we only run and display benchmarks for the gnolang package:

      - name: Run benchmark
        # add more benchmarks by adding additional lines for different packages;
        # or modify the -bench regexp.
        run: |
          set -xeuo pipefail && (
            go test ./gnovm/pkg/gnolang -bench='BenchmarkBenchdata' -benchmem -run='^$' -v -cpu=1,2
          ) | tee benchmarks.txt

https://gnolang.github.io/benchmarks/

@zivkovicmilos zivkovicmilos added 🗺️good first issue🗺️ Ideal for newcomer contributors help wanted Want to contribute? We recommend these issues. labels Dec 10, 2024
@Kouteki Kouteki moved this from Triage to Todo in 🧙‍♂️gno.land core team Dec 11, 2024
@thehowl
Copy link
Member

thehowl commented Dec 12, 2024

Let's make sure to only have a few and meaningful benchmarks, which can track how we're doing over time. I'd prefer if before getting started adding more benchmarks or enabling tracking on some existing ones, we used this issue to collect what information we'd like to get from the benchmarks. For instance, "How long does it take to reach consensus on a block on a single node?" - or other similar ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️good first issue🗺️ Ideal for newcomer contributors help wanted Want to contribute? We recommend these issues.
Projects
Development

No branches or pull requests

3 participants