Build failure when using make install

[stefann-01]

Build failure: BeginTransaction missing GasMeter argument

Description

After pulling the latest commit from master, when using make install command, the installation fails during gno installation due to a type mismatch in the BeginTransaction function call. The compiler indicates that a required GasMeter argument is missing in the function call in the linting code.

Your environment

• Go version go1.23.2
• OS and CPU architecture linux/amd64
• Gno commit hash causing the issue d69b552

Steps to reproduce

1. Clone the Gno repository
2. Checkout commit d69b552
3. Run make install from the root directory
4. Build fails during the gno installation step

Expected behaviour

The make install command should complete successfully.

Actual behaviour

The build fails.

Logs

go install ./cmd/gnokey
[+] 'gnokey' has been installed. Read more in ./gno.land/
make --no-print-directory -C ./gnovm    install
go install -ldflags "-X github.com/gnolang/gno/gnovm/pkg/gnoenv._GNOROOT=/home/stefan/gno_workspace/gno_orig/gno" ./cmd/gno
# github.com/gnolang/gno/gnovm/cmd/gno
cmd/gno/lint.go:147:34: not enough arguments in call to ts.BeginTransaction
        have ("github.com/gnolang/gno/tm2/pkg/store/types".Store, "github.com/gnolang/gno/tm2/pkg/store/types".Store)
        want ("github.com/gnolang/gno/tm2/pkg/store/types".Store, "github.com/gnolang/gno/tm2/pkg/store/types".Store, "github.com/gnolang/gno/tm2/pkg/store/types".GasMeter)
make[1]: *** [Makefile:43: install] Error 1
make: *** [Makefile:42: install.gno] Error 2```

[moul]

CI on #3315 should have identified the issue.

There is a fix for this problem: #3369. However, please do not close this issue before resolving the CI.

[n0izn0iz]

The problem is that this PR was merged without being based on latest master
It adds the offending line, but it was passing the CI because it did not have the gas meter changes in it's base

The root problem is that we don't enforce that branches are up to date before merge. The full way to fix that is:

• don't allow to merge branches that are not up-to-date
• disallow any branch-protection bypass (for example "Allow maintainers to bypass branch protections" option)
• optional: enable merge queue to be able to merge PRs without having to maintain them up-to-date manually

I must warn that the merge queue has tradeoffs and requires to modify workflows files to also target the merge-queue as well as properly marking required jobs in the repo config

[thehowl]

Moving discussion to #3395, and closing this because the issue is fixed.