store [nfc]: Dedupe details of how to report polling failure

Author: gnprice

lib/model/store.dart

@@ -930,10 +930,10 @@ class UpdateMachine {
 
       /// This only reports transient errors after reaching
       /// a pre-defined threshold of retries.
-      void maybeReportTransientError(String? message, {String? details}) {
+      void maybeReportToUserTransientError(Object error) {
         accumulatedTransientFailureCount++;
         if (accumulatedTransientFailureCount > transientFailureCountNotifyThreshold) {
-          reportErrorToUserBriefly(message, details: details);
+          _reportToUserErrorConnectingToServer(error);
         }
       }
 
@@ -963,12 +963,7 @@ class UpdateMachine {
               // The error is boring; skip reporting it to the user.
               // A [SocketException] is common when the app returns from sleep.
             } else {
-              final localizations = GlobalLocalizations.zulipLocalizations;
-              final serverUrl = store.connection.realmUrl.origin;
-              maybeReportTransientError(
-                localizations.errorConnectingToServerShort,
-                details: localizations.errorConnectingToServerDetails(
-                  serverUrl, e.toString()));
+              maybeReportToUserTransientError(e);
             }
             await (backoffMachine ??= BackoffMachine()).wait();
             if (_disposed) return;
@@ -1023,8 +1018,6 @@ class UpdateMachine {
       // Either way, the show must go on.  So reload server data from scratch.
 
       // First, log what happened.
-      final localizations = GlobalLocalizations.zulipLocalizations;
-      final serverUrl = store.connection.realmUrl.origin;
       switch (e) {
         case ZulipApiException(code: 'BAD_EVENT_QUEUE_ID'):
           assert(debugLog('Lost event queue for $store.  Replacing…'));
@@ -1046,10 +1039,7 @@ class UpdateMachine {
         default:
           assert(debugLog('BUG: Unexpected error in event polling: $e\n' // TODO(log)
             'Replacing event queue…'));
-          reportErrorToUserBriefly(
-            localizations.errorConnectingToServerShort,
-            details: localizations.errorConnectingToServerDetails(
-              serverUrl, e.toString()));
+          _reportToUserErrorConnectingToServer(e);
           // Similar story to the _EventHandlingException case;
           // separate only so that one can print more context.
           // The bug here could be in the server if it's an ApiRequestException,
@@ -1063,6 +1053,15 @@ class UpdateMachine {
     }
   }
 
+  void _reportToUserErrorConnectingToServer(Object error) {
+    final localizations = GlobalLocalizations.zulipLocalizations;
+    final serverUrl = store.connection.realmUrl.origin;
+    reportErrorToUserBriefly(
+      localizations.errorConnectingToServerShort,
+      details: localizations.errorConnectingToServerDetails(
+        serverUrl, error.toString()));
+  }
+
   /// Send this client's notification token to the server, now and if it changes.
   ///
   /// TODO The returned future isn't especially meaningful (it may or may not