Skip to content

Commit 7b40395

Browse files
committed
qa: Update QA code to new interface
With this commit, our QA code should work again. However, it still relies on C types in the C++ domain. We probably want to add a C++ wrapper around C VOLK. The idea: - add `volk.hh` - Include C++ magic in here. - Find idiomatic, modern C++ interface defition.
1 parent fcef50a commit 7b40395

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

lib/kernel_tests.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ std::vector<volk_test_case_t> init_test_list(volk_test_params_t test_params)
3333
test_params_power.set_scalar(2.5);
3434

3535
volk_test_params_t test_params_rotator(test_params);
36-
test_params_rotator.set_scalar(std::polar(1.0f, 0.1f));
36+
auto rotator_value = std::polar(1.0f, 0.1f);
37+
test_params_rotator.set_scalar(lv_32fc_t{rotator_value.real(), rotator_value.imag()});
3738
test_params_rotator.set_tol(1e-3);
3839

3940
std::vector<volk_test_case_t> test_cases;

lib/qa_utils.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -627,7 +627,7 @@ bool run_volk_tests(volk_func_desc_t desc,
627627
} else {
628628
run_cast_test1_s32f((volk_fn_1arg_s32f)(manual_func),
629629
test_data[i],
630-
scalar.real(),
630+
__real__ scalar,
631631
vlen,
632632
iter,
633633
arch_list[i]);
@@ -650,7 +650,7 @@ bool run_volk_tests(volk_func_desc_t desc,
650650
} else {
651651
run_cast_test2_s32f((volk_fn_2arg_s32f)(manual_func),
652652
test_data[i],
653-
scalar.real(),
653+
__real__ scalar,
654654
vlen,
655655
iter,
656656
arch_list[i]);
@@ -673,7 +673,7 @@ bool run_volk_tests(volk_func_desc_t desc,
673673
} else {
674674
run_cast_test3_s32f((volk_fn_3arg_s32f)(manual_func),
675675
test_data[i],
676-
scalar.real(),
676+
__real__ scalar,
677677
vlen,
678678
iter,
679679
arch_list[i]);

0 commit comments

Comments
 (0)