Work with fedora packagers to clean up volk.spec

[marcusmueller]

• CFLAGS should definitely include -O3
• There's still the disabled check in there, due to the by-now-fixed s390x problems
• yarda is a good maintainer, help them

[jdemel]

Could you add some context please? Which volk.spec file?
Where do you want to include -O3? In the Release build? I'd be hesitant to do so because I'd expect we rely on some -0.0f assignments and such somewhere.

I appreciate the package maintainer effort and would be glad to help.

A quick search yields:

./include/volk/sse2neon/tests/impl.cpp:96:                    mTestFloatPointer1[r5] = -0.0f;
./include/volk/sse2neon/tests/impl.cpp:97:                    mTestFloatPointer1[r6] = -0.0f;
./include/volk/sse2neon/tests/impl.cpp:98:                    mTestFloatPointer1[r7] = -0.0f;
./include/volk/sse2neon/tests/impl.cpp:99:                    mTestFloatPointer1[r8] = -0.0f;
./include/volk/volk_avx_intrinsics.h:194:    const __m256 sign_mask = _mm256_set1_ps(-0.0f);
./kernels/volk/volk_32f_tan_32f.h:48: *   in[9] = -0.000;

[marcusmueller]

Could you add some context please? Which volk.spec file?

https://src.fedoraproject.org/rpms/volk/tree/rawhide