Windows x64 MSVC Clang gnustep-2.0 -- Tests for NSURL* keep failing...

[gcasa]

Can we please correct the tests for this environment so that CI is not always RED? Otherwise it looks like it is ALWAYS failing.

[triplef]

See #474 (comment) for details.

[triplef]

@hmelder is it realistic to fix this in the short term, or should we just merge #478 to mark them as hopeful for now?

[hmelder]

I'll take a look at it. If you want the tests to be green rn, feel free to mark them as hopeful.

[gcasa]

  175 |                                                       [server port]]];
      |                                                       ^~~~~~~~~~~~~
15 warnings generated.
 Linking test_tool uploadTaskTests ...

base/NSURLSession/simpleTaskTests.m:
Failed file:  simpleTaskTests.m aborted without running all tests!

Is this test even compiling?

[hmelder]

Should be fixed now. Seems like something changed in the newer MSVC header files, so I needed to include WS2tcpip.h for socklen_t.

[triplef]

Unfortunately it looks like this test is still failing at least sometimes on Windows MSVC:

base/NSURLSession/simpleTaskTests.m:
Failed test:     (2025-02-06 19:52:45.095 +0000) simpleTaskTests.m:875 ... All transfers were completed before a timeout occurred

[hmelder]

Ah yes that seems to be a sporadic failure due to libdispatch swiftlang/swift-corelibs-libdispatch#833

[rfm]

A key feature of GNUstep is its support for writing highly portable app, so we should not have a dependency on libdispatch.
The first step to a fix would be to remove that dependency, and the second would be to conditionally allow its use for platforms/versions which are known to be working. I don't recall whether the previous NSURLSession implementation had the same problem; perhaps we should revert to it?

[rfm]

The older implementation is just as bad in using libdispatch, so there's no quick fix :-(

[hmelder]

I don't recall whether the previous NSURLSession implementation had the same problem; perhaps we should revert to it?

The old one is completely broken