fix(cli): use retryable client for ACME server calls (#2368)

ldez · web-flow · commit 65250372eea5 · 2024-12-10T15:02:07.000+01:00
diff --git a/cmd/setup.go b/cmd/setup.go
@@ -13,6 +13,7 @@ import (
 	"github.com/go-acme/lego/v4/lego"
 	"github.com/go-acme/lego/v4/log"
 	"github.com/go-acme/lego/v4/registration"
+	"github.com/hashicorp/go-retryablehttp"
 	"github.com/urfave/cli/v2"
 )
 
@@ -65,6 +66,12 @@ func newClient(ctx *cli.Context, acc registration.User, keyType certcrypto.KeyTy
 		}
 	}
 
+	retryClient := retryablehttp.NewClient()
+	retryClient.RetryMax = 5
+	retryClient.HTTPClient = config.HTTPClient
+
+	config.HTTPClient = retryClient.StandardClient()
+
 	client, err := lego.NewClient(config)
 	if err != nil {
 		log.Fatalf("Could not create client: %v", err)

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@ import (`
`13`	`13`	`"github.com/go-acme/lego/v4/lego"`
`14`	`14`	`"github.com/go-acme/lego/v4/log"`
`15`	`15`	`"github.com/go-acme/lego/v4/registration"`
	`16`	`+ "github.com/hashicorp/go-retryablehttp"`
`16`	`17`	`"github.com/urfave/cli/v2"`
`17`	`18`	`)`
`18`	`19`
`@@ -65,6 +66,12 @@ func newClient(ctx *cli.Context, acc registration.User, keyType certcrypto.KeyTy`
`65`	`66`	`}`
`66`	`67`	`}`
`67`	`68`
	`69`	`+ retryClient := retryablehttp.NewClient()`
	`70`	`+ retryClient.RetryMax = 5`
	`71`	`+ retryClient.HTTPClient = config.HTTPClient`
	`72`	`+`
	`73`	`+ config.HTTPClient = retryClient.StandardClient()`
	`74`	`+`
`68`	`75`	`client, err := lego.NewClient(config)`
`69`	`76`	`if err != nil {`
`70`	`77`	`log.Fatalf("Could not create client: %v", err)`