fix: create record

Author: ldez

providers/dns/manageengine/internal/client.go

@@ -93,22 +93,22 @@ func (c *Client) DeleteZoneRecord(ctx context.Context, zoneID int, recordID int)
 
 // CreateZoneRecord creates a "zone record".
 // https://pitstop.manageengine.com/portal/en/kb/articles/manageengine-clouddns-rest-api-documentation#POST_Create_10
-func (c *Client) CreateZoneRecord(ctx context.Context, zoneID int, record ZoneRecord) error {
+func (c *Client) CreateZoneRecord(ctx context.Context, zoneID int, record ZoneRecord) ([]ZoneRecord, error) {
 	endpoint := c.baseURL.JoinPath("dns", "domain", strconv.Itoa(zoneID), "records", "SPF_TXT")
 
 	req, err := newJSONRequest(ctx, http.MethodPost, endpoint, record)
 	if err != nil {
-		return err
+		return nil, err
 	}
 
-	var results APIResponse
+	var results []ZoneRecord
 
 	err = c.do(req, &results)
 	if err != nil {
-		return err
+		return nil, err
 	}
 
-	return nil
+	return results, nil
 }
 
 func (c *Client) do(req *http.Request, result any) error {

providers/dns/manageengine/internal/client_test.go

@@ -209,16 +209,43 @@ func TestClient_CreateZoneRecord(t *testing.T) {
 
 	record := ZoneRecord{}
 
-	err := client.CreateZoneRecord(context.Background(), 4, record)
+	zrs, err := client.CreateZoneRecord(context.Background(), 4, record)
 	require.NoError(t, err)
+
+	expected := []ZoneRecord{
+		{
+			ZoneID:           948,
+			SpfTxtDomainID:   4674,
+			DomainName:       "@.example.com",
+			DomainTTL:        3600,
+			DomainLocationID: 1,
+			RecordType:       "TXT",
+			Records: []Record{
+				{ID: 8065, Value: []string{"MS=ms66512834"}, Disabled: false, DomainID: 4674},
+			},
+		},
+		{
+			ZoneID:           948,
+			SpfTxtDomainID:   2972,
+			DomainName:       "example.com",
+			DomainTTL:        3600,
+			DomainLocationID: 1,
+			RecordType:       "TXT",
+			Records: []Record{
+				{ID: 6361, Value: []string{"v=DKIM1; k=rsa; t=s; p=XXXX"}, Disabled: false, DomainID: 2972},
+			},
+		},
+	}
+
+	assert.Equal(t, expected, zrs)
 }
 
 func TestClient_CreateZoneRecord_error(t *testing.T) {
 	client := setupTest(t, "POST /dns/domain/4/records/SPF_TXT", http.StatusUnauthorized, "error.json")
 
 	record := ZoneRecord{}
 
-	err := client.CreateZoneRecord(context.Background(), 4, record)
+	_, err := client.CreateZoneRecord(context.Background(), 4, record)
 	require.Error(t, err)
 
 	require.EqualError(t, err, "[status code: 401] Authentication credentials were not provided.")

providers/dns/manageengine/internal/fixtures/zone_record_create.json

@@ -1,3 +1,38 @@
-{
-  "message": "Record created successfully"
-}
+[
+  {
+    "spf_txt_domain_id": 4674,
+    "zone_id": 948,
+    "domain_name": "@.example.com",
+    "domain_ttl": 3600,
+    "record_type": "TXT",
+    "domain_location_id": 1,
+    "records": [
+      {
+        "record_id": 8065,
+        "value": [
+          "MS=ms66512834"
+        ],
+        "disabled": false,
+        "domain_id": 4674
+      }
+    ]
+  },
+  {
+    "spf_txt_domain_id": 2972,
+    "zone_id": 948,
+    "domain_name": "example.com",
+    "domain_ttl": 3600,
+    "record_type": "TXT",
+    "domain_location_id": 1,
+    "records": [
+      {
+        "record_id": 6361,
+        "value": [
+          "v=DKIM1; k=rsa; t=s; p=XXXX"
+        ],
+        "disabled": false,
+        "domain_id": 2972
+      }
+    ]
+  }
+]

providers/dns/manageengine/manageengine.go

@@ -109,7 +109,7 @@ func (d *DNSProvider) Present(domain, token, keyAuth string) error {
 		}},
 	}
 
-	err = d.client.CreateZoneRecord(ctx, zoneID, record)
+	_, err = d.client.CreateZoneRecord(ctx, zoneID, record)
 	if err != nil {
 		return fmt.Errorf("manageengine: create zone record: %w", err)
 	}