Add more tests (#2)

Author: unknwon

Diff for: clog_test.go

@@ -128,35 +128,46 @@ func Test_Clog(t *testing.T) {
 		So(New(_MEMORY, memoryConfig{}), ShouldBeNil)
 
 		Convey("Basic logging", func() {
+			buf.Reset()
 			wg.Add(1)
 			Trace("Level: %v", TRACE)
 			wg.Wait()
 			So(buf.String(), ShouldEqual, "[TRACE] Level: 0")
-			buf.Reset()
 
+			buf.Reset()
 			wg.Add(1)
 			Info("Level: %v", INFO)
 			wg.Wait()
 			So(buf.String(), ShouldEqual, "[ INFO] Level: 1")
-			buf.Reset()
 
+			buf.Reset()
 			wg.Add(1)
 			Warn("Level: %v", WARN)
 			wg.Wait()
 			So(buf.String(), ShouldEqual, "[ WARN] Level: 2")
-			buf.Reset()
 
+			buf.Reset()
 			wg.Add(1)
 			Error(0, "Level: %v", ERROR)
 			wg.Wait()
 			So(buf.String(), ShouldEqual, "[ERROR] Level: 3")
-			buf.Reset()
 
+			buf.Reset()
 			wg.Add(1)
 			Error(2, "Level: %v", ERROR)
 			wg.Wait()
 			So(buf.String(), ShouldContainSubstring, "clog_test.go")
-			buf.Reset()
 		})
 	})
+
+	Convey("Skip logs has lower level", t, func() {
+		So(New(_MEMORY, memoryConfig{
+			Level: ERROR,
+		}), ShouldBeNil)
+
+		buf.Reset()
+		Trace("Level: %v", TRACE)
+		Trace("Level: %v", INFO)
+		So(buf.String(), ShouldEqual, "")
+	})
 }

Diff for: file_test.go

@@ -15,6 +15,8 @@
 package clog
 
 import (
+	"io/ioutil"
+	"os"
 	"testing"
 
 	. "github.com/smartystreets/goconvey/convey"
@@ -51,3 +53,17 @@ func Test_file_Init(t *testing.T) {
 		})
 	})
 }
+
+func Test_file_rotateFilename(t *testing.T) {
+	Convey("Get rotate filename", t, func() {
+		f := &file{
+			filename: "test/test.log",
+		}
+		os.Remove("test/test.log.2017-03-05")
+		So(f.rotateFilename("2017-03-05"), ShouldEqual, "test/test.log.2017-03-05")
+
+		// Pretend one log file already exists
+		ioutil.WriteFile("test/test.log.2017-03-05", []byte(""), os.ModePerm)
+		So(f.rotateFilename("2017-03-05"), ShouldEqual, "test/test.log.2017-03-05.001")
+	})
+}

Diff for: slack.go

@@ -92,8 +92,12 @@ func (s *slack) ExchangeChans(errorChan chan<- error) chan *Message {
 	return s.msgChan
 }
 
+func buildSlackAttachment(msg *Message) string {
+	return fmt.Sprintf(_SLACK_ATTACHMENT, msg.Body, slackColors[msg.Level])
+}
+
 func (s *slack) write(msg *Message) {
-	attachment := fmt.Sprintf(_SLACK_ATTACHMENT, msg.Body, slackColors[msg.Level])
+	attachment := buildSlackAttachment(msg)
 	resp, err := http.Post(s.url, "application/json", bytes.NewReader([]byte(attachment)))
 	if err != nil {
 		s.errorChan <- fmt.Errorf("slack: %v", err)

Diff for: slack_test.go

@@ -45,3 +45,19 @@ func Test_slack_Init(t *testing.T) {
 		})
 	})
 }
+
+func Test_buildSlackAttchment(t *testing.T) {
+	Convey("Build Slack attachment", t, func() {
+		So(buildSlackAttachment(&Message{
+			Level: INFO,
+			Body:  "test message",
+		}), ShouldEqual, `{
+	"attachments": [
+		{
+			"text": "test message",
+			"color": "#3aa3e3"
+		}
+	]
+}`)
+	})
+}