Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better end user visibility for failures in agit PRs #32965

Open
TheFox0x7 opened this issue Dec 23, 2024 · 3 comments
Open

Better end user visibility for failures in agit PRs #32965

TheFox0x7 opened this issue Dec 23, 2024 · 3 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@TheFox0x7
Copy link
Contributor

Feature Description

The error messages in agit PRs aren't very visible to the end user. I think that adding an error label for fails would make them pop out more (if one has color enabled). See screenshots for full options.

I encountered this while trying to submit an agit PR to docs, which uncovered a missing UserMsg, which would've been helpful:

log.Error(err.Error())
ctx.JSON(http.StatusInternalServerError, private.Response{
Err: err.Error(),
})

and I've glanced over it before, so I think having a color before it would be helpful.

Similarly an instruction for setting up branch tracking would be a good improvement - no idea how to set it up though.

Screenshots

image
Possible options:
image

@TheFox0x7 TheFox0x7 added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Dec 23, 2024
@lunny
Copy link
Member

lunny commented Dec 23, 2024

I resolve the problems via resync of all git hooks because there are no proc-receive hooks under this repository. I think there is no migration for git hooks when introducing the agit feature.

@TheFox0x7
Copy link
Contributor Author

I can reproduce this (or similar) fault locally - lack of collaborator status prevents user from submitting agit PR, which is not forwarded to them:

remote: Gitea: Internal Server Error (no message for end users)
remote: error: proc-receive exited abnormally

I in the original text I meant that the error should be made more visible (and descriptive), which I figured is more of a enhancement that an a bug. Some errors - like the lack of collaborator status - are worth forwarding to user in my opinion.
Apologies if I worded it in a confusing way originally.

@wxiaoguang
Copy link
Contributor

If I understand correctly , only the "Gitea:" prefixed line is outputed by Gitea.

Other lines are from git, which are not controllable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

3 participants