refactor: improve logging for unimplemented ErrorTranslator in TranslateError config (#7225)

Invidam · web-flow · commit 8020e8c166ca · 2024-10-09T19:29:48.000+08:00
diff --git a/gorm.go b/gorm.go
@@ -189,6 +189,12 @@ func Open(dialector Dialector, opts ...Option) (db *DB, err error) {
 				_ = db.Close()
 			}
 		}
+
+		if config.TranslateError {
+			if _, ok := db.Dialector.(ErrorTranslator); !ok {
+				config.Logger.Warn(context.Background(), "The TranslateError option is enabled, but the Dialector %s does not implement ErrorTranslator.", db.Dialector.Name())
+			}
+		}
 	}
 
 	if config.PrepareStmt {

Original file line number	Diff line number	Diff line change
`@@ -189,6 +189,12 @@ func Open(dialector Dialector, opts ...Option) (db *DB, err error) {`
`189`	`189`	`_ = db.Close()`
`190`	`190`	`}`
`191`	`191`	`}`
	`192`	`+`
	`193`	`+ if config.TranslateError {`
	`194`	`+ if _, ok := db.Dialector.(ErrorTranslator); !ok {`
	`195`	`+ config.Logger.Warn(context.Background(), "The TranslateError option is enabled, but the Dialector %s does not implement ErrorTranslator.", db.Dialector.Name())`
	`196`	`+ }`
	`197`	`+ }`
`192`	`198`	`}`
`193`	`199`
`194`	`200`	`if config.PrepareStmt {`