String performance optimization

icpd · icpd · commit 8e3fc5e1063c · 2022-03-29T14:52:55.000+08:00
diff --git a/version.go b/version.go
@@ -4,7 +4,6 @@ import (
 	"database/sql"
 	"database/sql/driver"
 	"encoding/json"
-	"fmt"
 	"reflect"
 	"strconv"
 	"sync"
@@ -136,6 +135,6 @@ func (v VersionUpdateClause) ModifyStatement(stmt *gorm.Statement) {
 		stmt.Dest = d
 	}
 
-	stmt.SetColumn(v.Field.DBName, clause.Expr{SQL: fmt.Sprintf("%s+1", stmt.Quote(v.Field.DBName))}, true)
+	stmt.SetColumn(v.Field.DBName, clause.Expr{SQL: stmt.Quote(v.Field.DBName) + "+1"}, true)
 	stmt.Clauses["version_enabled"] = clause.Clause{}
 }

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@ import (`
`4`	`4`	`"database/sql"`
`5`	`5`	`"database/sql/driver"`
`6`	`6`	`"encoding/json"`
`7`		`- "fmt"`
`8`	`7`	`"reflect"`
`9`	`8`	`"strconv"`
`10`	`9`	`"sync"`
`@@ -136,6 +135,6 @@ func (v VersionUpdateClause) ModifyStatement(stmt *gorm.Statement) {`
`136`	`135`	`stmt.Dest = d`
`137`	`136`	`}`
`138`	`137`
`139`		`- stmt.SetColumn(v.Field.DBName, clause.Expr{SQL: fmt.Sprintf("%s+1", stmt.Quote(v.Field.DBName))}, true)`
	`138`	`+ stmt.SetColumn(v.Field.DBName, clause.Expr{SQL: stmt.Quote(v.Field.DBName) + "+1"}, true)`
`140`	`139`	`stmt.Clauses["version_enabled"] = clause.Clause{}`
`141`	`140`	`}`