Feat/manager from context return error (#544)

* feat: ManagerFromContext returns (Manager, error) instead of Manager

BREAKING CHANGE: ManagerFromContext now returns (Manager, error) tuple.
Returns ErrNoManagerFoundInContext when manager is not found in context.

- Update ManagerFromContext signature in manager.go
- Update all callers in shortcuts.go, scope.go, middleware.go
- Add ErrNoManagerFoundInContext error definition in errors.go

* wip

Author: eatmoreapple

errors.go

@@ -35,6 +35,9 @@ var (
 
 	// ErrNoStatementFound is an error that is returned when the statement is not found.
 	ErrNoStatementFound = errors.New("no statement found")
+
+	// ErrNoManagerFoundInContext is an error that is returned when the manager is not found in context.
+	ErrNoManagerFoundInContext = errors.New("no manager found in context")
 )
 
 // nodeUnclosedError is an error that is returned when the node is not closed.

manager.go

@@ -149,9 +149,12 @@ func managerFromContext(ctx context.Context) (Manager, bool) {
 }
 
 // ManagerFromContext returns the Manager from the context.
-func ManagerFromContext(ctx context.Context) Manager {
-	manager, _ := managerFromContext(ctx)
-	return manager
+func ManagerFromContext(ctx context.Context) (Manager, error) {
+	manager, ok := managerFromContext(ctx)
+	if !ok {
+		return nil, ErrNoManagerFoundInContext
+	}
+	return manager, nil
 }
 
 // ContextWithManager returns a new context with the given Manager.

middleware.go

@@ -375,7 +375,7 @@ func (m *useGeneratedKeysMiddleware) ExecContext(stmt Statement, configuration C
 
 // isInTransaction checks if the current context is within a transaction
 func isInTransaction(ctx context.Context) bool {
-	manager := ManagerFromContext(ctx)
+	manager, _ := ManagerFromContext(ctx)
 	return IsTxManager(manager)
 }
 
@@ -448,7 +448,7 @@ func (t *TxSensitiveDataSourceSwitchMiddleware) chooseDataSourceName(dataSourceN
 // - The manager is not an Engine
 // - The chosen datasource is the same as the requested one
 func (t *TxSensitiveDataSourceSwitchMiddleware) switchDataSource(ctx context.Context, dataSourceName string) (context.Context, error) {
-	manager := ManagerFromContext(ctx)
+	manager, _ := ManagerFromContext(ctx)
 	engine, ok := manager.(*Engine)
 	if !ok {
 		// In current implementation, this case should never happen.

scope.go

@@ -48,7 +48,10 @@ var ErrCommitOnSpecific = tx.ErrCommitOnSpecific
 //			// handle error
 //		}
 func Transaction(ctx context.Context, handler func(ctx context.Context) error, opts ...tx.TransactionOptionFunc) (err error) {
-	manager := ManagerFromContext(ctx)
+	manager, err := ManagerFromContext(ctx)
+	if err != nil {
+		return err
+	}
 	engine, ok := manager.(*Engine)
 	if !ok {
 		return ErrInvalidManager
@@ -71,7 +74,10 @@ func Transaction(ctx context.Context, handler func(ctx context.Context) error, o
 // If the manager is a TxManager, it will execute the handler within the existing transaction.
 // Otherwise, it will create a new transaction and execute the handler within the new transaction.
 func NestedTransaction(ctx context.Context, handler func(ctx context.Context) error, opts ...tx.TransactionOptionFunc) (err error) {
-	manager := ManagerFromContext(ctx)
+	manager, err := ManagerFromContext(ctx)
+	if err != nil {
+		return err
+	}
 	if IsTxManager(manager) {
 		return handler(ctx)
 	}

shortcuts.go

@@ -27,23 +27,32 @@ import (
 // QueryContext executes a query with the provided context and scans a single result into T.
 // (ctx must contain a Manager via ManagerFromContext)
 func QueryContext[T any](ctx context.Context, statement, param any) (result T, err error) {
-	manager := ManagerFromContext(ctx)
+	manager, err := ManagerFromContext(ctx)
+	if err != nil {
+		return result, err
+	}
 	executor := NewGenericManager[T](manager).Object(statement)
 	return executor.QueryContext(ctx, param)
 }
 
 // ExecContext executes a statement that does not return rows and returns a sql.Result.
 // (ctx must contain a Manager via ManagerFromContext)
 func ExecContext(ctx context.Context, statement, param any) (result sql.Result, err error) {
-	manager := ManagerFromContext(ctx)
+	manager, err := ManagerFromContext(ctx)
+	if err != nil {
+		return nil, err
+	}
 	executor := manager.Object(statement)
 	return executor.ExecContext(ctx, param)
 }
 
 // QueryListContext executes a query and returns a slice of T. Rows are closed after reading.
 // (ctx must contain a Manager via ManagerFromContext)
 func QueryListContext[T any](ctx context.Context, statement, param any) (result []T, err error) {
-	manager := ManagerFromContext(ctx)
+	manager, err := ManagerFromContext(ctx)
+	if err != nil {
+		return nil, err
+	}
 	rows, err := manager.Object(statement).QueryContext(ctx, param)
 	if err != nil {
 		return nil, err
@@ -55,7 +64,10 @@ func QueryListContext[T any](ctx context.Context, statement, param any) (result
 // QueryList2Context executes a query and returns a slice of pointers to T. Rows are closed after reading.
 // (ctx must contain a Manager via ManagerFromContext)
 func QueryList2Context[T any](ctx context.Context, statement, param any) (result []*T, err error) {
-	manager := ManagerFromContext(ctx)
+	manager, err := ManagerFromContext(ctx)
+	if err != nil {
+		return nil, err
+	}
 	rows, err := manager.Object(statement).QueryContext(ctx, param)
 	if err != nil {
 		return nil, err
@@ -68,7 +80,10 @@ func QueryList2Context[T any](ctx context.Context, statement, param any) (result
 // Rows are automatically closed when iteration completes or stops.
 // (ctx must contain a Manager via ManagerFromContext)
 func QueryIterContext[T any](ctx context.Context, statement, param any) (sqllib.Iterator[T], error) {
-	manager := ManagerFromContext(ctx)
+	manager, err := ManagerFromContext(ctx)
+	if err != nil {
+		return nil, err
+	}
 	rows, err := manager.Object(statement).QueryContext(ctx, param)
 	if err != nil {
 		return nil, err